Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fixed "Error: TypeError: Cannot read properties of undefined (readi… #247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions __tests__/__snapshots__/java-junit.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6878,3 +6878,57 @@ at java.lang.Thread.run(Thread.java:748)
"totalTime": 2126531.0000000005,
}
`;

exports[`java-junit tests report from jest in junit format 1`] = `
TestRunResult {
"path": "fixtures/external/java/test-report-jest.xml",
"suites": Array [
TestSuiteResult {
"groups": Array [
TestGroupResult {
"name": "MaintenanceFilterComponent",
"tests": Array [
TestCaseResult {
"error": Object {
"details": undefined,
"line": undefined,
"message": undefined,
"path": undefined,
},
"name": "should create",
"result": "failed",
"time": 0,
},
],
},
],
"name": "maintenance/maintenance-filter/maintenance-filter.component.spec.ts",
"totalTime": 1204,
},
TestSuiteResult {
"groups": Array [
TestGroupResult {
"name": "AppComponent",
"tests": Array [
TestCaseResult {
"error": undefined,
"name": "should create the app",
"result": "success",
"time": 0,
},
TestCaseResult {
"error": undefined,
"name": "should forward to login page",
"result": "success",
"time": 0,
},
],
},
],
"name": "app.component.spec.ts",
"totalTime": 1244,
},
],
"totalTime": undefined,
}
`;
25 changes: 25 additions & 0 deletions __tests__/fixtures/external/java/test-report-jest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
<testsuite id="0" name="maintenance/maintenance-filter/maintenance-filter.component.spec.ts" errors="0" package="maintenance-filter.component.spec.ts" hostname="localhost" tests="1" failures="1" time="1.204" timestamp="2023-05-22T13:04:47">
<properties>
</properties>
<testcase classname="MaintenanceFilterComponent" name="should create" time="0">
<failure message="NullInjectorError: R3InjectorError(DynamicTestModule)[InjectionToken L10N_LOCALE -&gt; InjectionToken L10N_LOCALE]:
NullInjectorError: No provider for InjectionToken L10N_LOCALE!
at processTicksAndRejections (node:internal/process/task_queues:96:5)" type="AssertionError">
</failure>
</testcase>
<system-out/>
<system-err/>
</testsuite>
<testsuite id="1" name="app.component.spec.ts" errors="0" package="app.component.spec.ts" hostname="localhost" tests="2" failures="0" time="1.244" timestamp="2023-05-22T13:04:47">
<properties>
</properties>
<testcase classname="AppComponent" name="should create the app" time="0">
</testcase>
<testcase classname="AppComponent" name="should forward to login page" time="0">
</testcase>
<system-out/>
<system-err/>
</testsuite>
</testsuites>
22 changes: 22 additions & 0 deletions __tests__/java-junit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

it('report from apache/pulsar single suite test results matches snapshot', async () => {
const fixturePath = path.join(
__dirname,

Check failure on line 28 in __tests__/java-junit.test.ts

View workflow job for this annotation

GitHub Actions / Workflow Report

__tests__/java-junit.test.ts â–º java-junit tests â–º report from jest in junit format

Failed test found in: jest-junit.xml Error: Error: expect(received).toMatchSnapshot()
Raw output
Error: expect(received).toMatchSnapshot()

Snapshot name: `java-junit tests report from jest in junit format 1`

- Snapshot  - 6
+ Received  + 6

@@ -1,15 +1,15 @@
  TestRunResult {
    "path": "fixtures/external/java/test-report-jest.xml",
-   "suites": Array [
+   "suites": [
      TestSuiteResult {
-       "groups": Array [
+       "groups": [
          TestGroupResult {
            "name": "MaintenanceFilterComponent",
-           "tests": Array [
+           "tests": [
              TestCaseResult {
-               "error": Object {
+               "error": {
                  "details": undefined,
                  "line": undefined,
                  "message": undefined,
                  "path": undefined,
                },
@@ -22,14 +22,14 @@
        ],
        "name": "maintenance/maintenance-filter/maintenance-filter.component.spec.ts",
        "totalTime": 1204,
      },
      TestSuiteResult {
-       "groups": Array [
+       "groups": [
          TestGroupResult {
            "name": "AppComponent",
-           "tests": Array [
+           "tests": [
              TestCaseResult {
                "error": undefined,
                "name": "should create the app",
                "result": "success",
                "time": 0,
    at /home/runner/work/test-reporter/test-reporter/__tests__/java-junit.test.ts:91:20
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/test-reporter/test-reporter/__tests__/java-junit.test.ts:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
'fixtures',
'external',
'java',
Expand Down Expand Up @@ -73,6 +73,28 @@
fs.writeFileSync(outputPath, report)
})

it('report from jest in junit format', async () => {
const fixturePath = path.join(__dirname, 'fixtures', 'external', 'java', 'test-report-jest.xml')
const trackedFilesPath = path.join(__dirname, 'fixtures', 'external', 'java', 'files.txt')
const outputPath = path.join(__dirname, '__outputs__', 'pulsar-test-results.md')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pulsar-test-results.md output file is used by another test.

const filePath = normalizeFilePath(path.relative(__dirname, fixturePath))
const fileContent = fs.readFileSync(fixturePath, {encoding: 'utf8'})

const trackedFiles = fs.readFileSync(trackedFilesPath, {encoding: 'utf8'}).split(/\n\r?/g)
const opts: ParseOptions = {
parseErrors: true,
trackedFiles
}

const parser = new JavaJunitParser(opts)
const result = await parser.parse(filePath, fileContent)
expect(result).toMatchSnapshot()

const report = getReport([result])
fs.mkdirSync(path.dirname(outputPath), {recursive: true})
fs.writeFileSync(outputPath, report)
})

it('parses empty failures in test results', async () => {
const fixturePath = path.join(__dirname, 'fixtures', 'external', 'java', 'empty_failures.xml')
const filePath = normalizeFilePath(path.relative(__dirname, fixturePath))
Expand Down
4 changes: 2 additions & 2 deletions src/utils/parse-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ export function parseIsoDate(str: string): Date {
}

export function getFirstNonEmptyLine(stackTrace: string): string | undefined {
const lines = stackTrace?.split(/\r?\n/g)
return lines?.find(str => !/^\s*$/.test(str))
const lines = stackTrace ? stackTrace.split(/\r?\n/g) : []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is no longer necessary - see #258

return lines.find(str => !/^\s*$/.test(str))
}
Loading