generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 fixed "Error: TypeError: Cannot read properties of undefined (readi… #247
Open
uebelack
wants to merge
2
commits into
dorny:main
Choose a base branch
from
uebelack:split_not_defined_error_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<testsuites> | ||
<testsuite id="0" name="maintenance/maintenance-filter/maintenance-filter.component.spec.ts" errors="0" package="maintenance-filter.component.spec.ts" hostname="localhost" tests="1" failures="1" time="1.204" timestamp="2023-05-22T13:04:47"> | ||
<properties> | ||
</properties> | ||
<testcase classname="MaintenanceFilterComponent" name="should create" time="0"> | ||
<failure message="NullInjectorError: R3InjectorError(DynamicTestModule)[InjectionToken L10N_LOCALE -> InjectionToken L10N_LOCALE]: | ||
NullInjectorError: No provider for InjectionToken L10N_LOCALE! | ||
at processTicksAndRejections (node:internal/process/task_queues:96:5)" type="AssertionError"> | ||
</failure> | ||
</testcase> | ||
<system-out/> | ||
<system-err/> | ||
</testsuite> | ||
<testsuite id="1" name="app.component.spec.ts" errors="0" package="app.component.spec.ts" hostname="localhost" tests="2" failures="0" time="1.244" timestamp="2023-05-22T13:04:47"> | ||
<properties> | ||
</properties> | ||
<testcase classname="AppComponent" name="should create the app" time="0"> | ||
</testcase> | ||
<testcase classname="AppComponent" name="should forward to login page" time="0"> | ||
</testcase> | ||
<system-out/> | ||
<system-err/> | ||
</testsuite> | ||
</testsuites> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,6 @@ export function parseIsoDate(str: string): Date { | |
} | ||
|
||
export function getFirstNonEmptyLine(stackTrace: string): string | undefined { | ||
const lines = stackTrace?.split(/\r?\n/g) | ||
return lines?.find(str => !/^\s*$/.test(str)) | ||
const lines = stackTrace ? stackTrace.split(/\r?\n/g) : [] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is no longer necessary - see #258 |
||
return lines.find(str => !/^\s*$/.test(str)) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pulsar-test-results.md
output file is used by another test.