Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCOV Support #352

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Add LCOV Support #352

wants to merge 17 commits into from

Conversation

j-catania
Copy link
Collaborator

No description provided.

j-catania and others added 12 commits August 12, 2023 15:51
Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js) from 0.4.23 to 0.5.0.
- [Commits](https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0)

---
updated-dependencies:
- dependency-name: xml2js
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
# Conflicts:
#	__tests__/lcov.test.ts
#	action.yml
#	package-lock.json
#	package.json
#	src/main.ts
@j-catania j-catania added the enhancement New feature or request label Jan 2, 2024
@j-catania j-catania added this to the v1.8.0 milestone Jan 2, 2024
@j-catania j-catania linked an issue Jan 3, 2024 that may be closed by this pull request
@j-catania
Copy link
Collaborator Author

Evolution of the report : report

@j-catania j-catania self-assigned this Jan 3, 2024
@j-catania j-catania removed this from the v1.8.0 milestone Jan 12, 2024
@j-catania
Copy link
Collaborator Author

This is now using a lcov.info file !
Report look like that now
image

@j-catania
Copy link
Collaborator Author

@jozefizso, @dorny,

I don't known what to do with the 3 tests.
Actually, if percentage of lines, branches and functions are less than 80%, the test is marked as failed (as you can see here).

What do you think about this POC ?

@dorny
Copy link
Owner

dorny commented Jan 15, 2024

So the parser takes information about the coverage of each file and represents the results as 3 tests - for lines, functions, and branches. Do I understand it correctly?

IMHO, this feels quite hacky. I can imagine using such an approach for my private work, but I don't think it's a good idea to have this in public action. It might confuse users. Another issue is the hardcoded 80% threshold, this would have to be configurable in the final implementation.

I think if lcov should be supported by test-reporter, it would require a specialized implementation for producing output in a different layout and also adding input variables for a passing threshold. The output should probably not only show if it passed but also an actual number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding coverage reports (e.g. for lcov format)
2 participants