-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging/next major #56
Conversation
7d4b4b7
to
97879bf
Compare
d52c342
to
b490b16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some REALLY AWSOME work! 🚀🔥
let's just make the requested changes
c41b730
to
1443a34
Compare
hilda/lldb_importer.py
Outdated
lldb_python_path = result.stdout.strip() | ||
return lldb_python_path | ||
except subprocess.CalledProcessError as e: | ||
print(f'Error running lldb: {e}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we raise this instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise where discussed
db4821d
to
bf98c5a
Compare
bf98c5a
to
da627ea
Compare
- remove the need of invoking `lldb` directly (instead create own `SBDebugger` instance) - add F-keys as new hotkeys - improve IPython shell experience (rc scripts, magic functions, etc) - use `pre-commit` hook in order to enforce linter errors
da627ea
to
15f1938
Compare
No description provided.