Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging/next major #56

Merged
merged 4 commits into from
May 23, 2024
Merged

Staging/next major #56

merged 4 commits into from
May 23, 2024

Conversation

netanelc305
Copy link
Collaborator

No description provided.

@doronz88 doronz88 force-pushed the staging/next_major branch 4 times, most recently from 7d4b4b7 to 97879bf Compare May 16, 2024 14:20
README.md Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
@doronz88 doronz88 force-pushed the staging/next_major branch 4 times, most recently from d52c342 to b490b16 Compare May 19, 2024 08:08
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some REALLY AWSOME work! 🚀🔥
let's just make the requested changes

.github/workflows/python-app.yml Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
hilda/cli.py Outdated Show resolved Hide resolved
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/cli.py Show resolved Hide resolved
hilda/lldb_importer.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
.github/workflows/python-app.yml Show resolved Hide resolved
hilda/cli.py Show resolved Hide resolved
hilda/ipython_extensions/events.py Show resolved Hide resolved
hilda/hilda_client.py Outdated Show resolved Hide resolved
@doronz88 doronz88 force-pushed the staging/next_major branch 3 times, most recently from c41b730 to 1443a34 Compare May 22, 2024 13:19
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/launch_lldb.py Outdated Show resolved Hide resolved
hilda/lldb_importer.py Outdated Show resolved Hide resolved
lldb_python_path = result.stdout.strip()
return lldb_python_path
except subprocess.CalledProcessError as e:
print(f'Error running lldb: {e}')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we raise this instead?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raise where discussed

hilda/lldb_importer.py Outdated Show resolved Hide resolved
hilda/ipython_extensions/events.py Show resolved Hide resolved
hilda/ipython_extensions/events.py Outdated Show resolved Hide resolved
@doronz88 doronz88 force-pushed the staging/next_major branch 7 times, most recently from db4821d to bf98c5a Compare May 23, 2024 10:34
- remove the need of invoking `lldb` directly (instead create own `SBDebugger` instance)
- add F-keys as new hotkeys
- improve IPython shell experience (rc scripts, magic functions, etc)
- use `pre-commit` hook in order to enforce linter errors
@doronz88 doronz88 merged commit 5050b8d into main May 23, 2024
5 checks passed
@doronz88 doronz88 deleted the staging/next_major branch May 23, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants