Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for sub languages on the "backend" #158

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

Mathys-Gasnier
Copy link
Collaborator

Description

Add the ability to parse sub languages to the snippet parser, and to consolidate them.

To consolidate them we save the json and svg with the following name format language--subLanguage.
I didn't want to put them under folders as i think it would complexify things in the frontend.
Also, as we are using slugify to generate the language and subLanguage name, a -- can never occur outside of that usecase.

As it stands we support only 1 level of nesting languages.

Some small changes also include renaming some names key to name (lang in _index.json and categoryName)

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe): Consolidation script update to start adding support to sub languages

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Related to #136

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 8261129
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67781099b88d1100088284be
😎 Deploy Preview https://deploy-preview-158--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mathys-Gasnier
Copy link
Collaborator Author

The preview doesn't work because the consolidation hasn't run, i'm going to push a commit manually doing it

@majvax majvax added the enhancement New feature or request label Jan 4, 2025
@Mathys-Gasnier Mathys-Gasnier merged commit 3f3137a into dostonnabotov:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants