Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Smoothed modal animation + reduced motion #174

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

Yugveer06
Copy link
Contributor

Description

  • Replaced framer-motion package with new motion package
  • Fixed the snippet list item animation.
  • Added smooth layout animation for snippet modal.
  • Added reduced motion support for accessibility purposes.

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe): enhanced animations

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots
  • Snippet list and layout animations
    2025-01-04 18-46-57

  • Reduced motion example
    2025-01-04 18-52-52

src/types/index.ts Outdated Show resolved Hide resolved
@majvax majvax added the enhancement New feature or request label Jan 4, 2025
Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait on another review before moving on with the PR

package-lock.json Outdated Show resolved Hide resolved
src/components/SnippetList.tsx Outdated Show resolved Hide resolved
@Yugveer06 Yugveer06 requested a review from psychlone77 January 5, 2025 10:56
Copy link
Collaborator

@psychlone77 psychlone77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. 🫡
Thank you for your time and contribution to the project. @Yugveer06.

@psychlone77 psychlone77 merged commit 6db694d into dostonnabotov:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants