Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Golang category and basic hello,world snippet #176

Closed
wants to merge 0 commits into from

Conversation

AmeerMoustafa
Copy link

@AmeerMoustafa AmeerMoustafa commented Jan 4, 2025

Description

Created a Golang section and added a basic hello world snippet with comments.

Type of Change

* [x]  ✨ New snippet

* [ ]  πŸ›  Improvement to an existing snippet

* [ ]  🐞 Bug fix

* [ ]  πŸ“– Documentation update

* [ ]  πŸ”§ Other (please describe):

Checklist

* [x]  I have tested my code and verified it works as expected.

* [x]  My code follows the style and contribution guidelines of this project.

* [x]  Comments are added where necessary for clarity.

* [ ]  Documentation has been updated (if applicable).

* [x]  There are no new warnings or errors from my changes.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I notice that only one snippet has been added, we don't accept new language unless their author provides at least one or two snippets more than the hello world one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this snippet has too much comments, also the tags of a snippet shouldn't include the name of the language it's using

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I will add some more snippets and remove some comments. Added them since technically this is the "basics" section, so I assumed that people would not already be familiar with the language.

majvax

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants