Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippet] SASS function to convert px to rem #178

Merged
merged 13 commits into from
Jan 5, 2025
Merged

[Snippet] SASS function to convert px to rem #178

merged 13 commits into from
Jan 5, 2025

Conversation

gihanrangana
Copy link
Contributor

Description

A new snippet was added for SASS under the typography category. Which is a function to convert px values to rem

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Closes #

Additional Context

Screenshots (Optional)

Click to view screenshots./summary>

Mathys-Gasnier
Mathys-Gasnier requested changes Jan 4, 2025
View reviewed changes
.github/workflows/auto-sync.yml Outdated Show resolved Hide resolved
snippets/scss/typography/px-to-rem-helper.md Outdated Show resolved Hide resolved
snippets/scss/typography/px-to-rem-helper.md Outdated Show resolved Hide resolved
@dostonnabotov dostonnabotov added the Guidelines Issue Your PR has been found to not follow the CONTRIBUTING.md guidelines label Jan 4, 2025
@majvax majvax added the Snippets label Jan 4, 2025
@gihanrangana gihanrangana requested a review from saminjay as a code owner January 5, 2025 04:08
@Mathys-Gasnier Mathys-Gasnier merged commit 8508752 into dostonnabotov:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier approved these changes

@majvax majvax Awaiting requested review from majvax majvax is a code owner

@saminjay saminjay Awaiting requested review from saminjay saminjay is a code owner

Assignees
No one assigned
Labels
Guidelines Issue Your PR has been found to not follow the CONTRIBUTING.md guidelines Snippets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gihanrangana @Mathys-Gasnier @majvax @dostonnabotov @actions-user