Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snippets] java date/time snippets #188

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

Mcbencrafter
Copy link
Contributor

Description

Added multiple date/time related snippets in java including:

  • converting a given time duration to a human-readable strings in the formats "hh:mm:ss", "hh:mm" and "mm:ss"
  • converting a given time to datetime strings of formats "MM/dd/yyyy hh:mm:ss a" and "dd.MM.yyyy HH:mm:ss"

Type of Change

  • ✨ New snippet
  • 🛠 Improvement to an existing snippet
  • 🐞 Bug fix
  • 📖 Documentation update
  • 🔧 Other (please describe):

Checklist

  • I have tested my code and verified it works as expected.
  • My code follows the style and contribution guidelines of this project.
  • Comments are added where necessary for clarity.
  • Documentation has been updated (if applicable).
  • There are no new warnings or errors from my changes.

Related Issues

Additional Context

Screenshots (Optional)

Click to view screenshots

@Mathys-Gasnier
Copy link
Collaborator

Thanks for your contribution, but as the snippets don't follow our formatting conventions, I will not be able to review them, please fix it before re requesting for a review, take a look at existing snippets to understand how to make them

@Mcbencrafter
Copy link
Contributor Author

Thanks for your contribution, but as the snippets don't follow our formatting conventions, I will not be able to review them, please fix it before re requesting for a review, take a look at existing snippets to understand how to make them

Are you talking about these formatting conventions https://github.com/dostonnabotov/quicksnip/blob/main/CONTRIBUTING.md ? Or are there specific formatting conventions for the individual languages? I had a look at the basic hello world snippet in java and orientated myself on it.

@Mathys-Gasnier
Copy link
Collaborator

Take a look at #177

@Mcbencrafter
Copy link
Contributor Author

Formatting should be fine now, i am now using the same formatting as in #177

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Mathys-Gasnier Mathys-Gasnier merged commit 9181837 into dostonnabotov:main Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants