Updating to use vite HMR to consolidate snippets #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majvax
approved these changes
Jan 6, 2025
saminjay
requested changes
Jan 7, 2025
dostonnabotov
approved these changes
Jan 7, 2025
saminjay
approved these changes
Jan 7, 2025
|
Awesome work. We also need to update the guidelines for contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the need to run
snippets:consolidateto consolidate snippets, instead we are now using a custom vite plugin that builds snippets when vite runs (build or dev mode).It allows for less conflicts on PRs, and leaves the responsability of consolidating to the server instead of leaving the repo store them.
TLDR: consolidated snippets removed, workflow removed, custom plugin in vite config to consolidate.
Type of Change