Skip to content

Commit

Permalink
Fixing broken trunk after E2E tests were included in the CICD pipeline (
Browse files Browse the repository at this point in the history
#30150)

Co-authored-by: Daniel Enrique Colina Rodríguez <[email protected]>
  • Loading branch information
victoralfaro-dotcms and dcolina authored Sep 26, 2024
1 parent eec3e87 commit 34b682f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/cicd_1-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@ jobs:
postman: ${{ needs.initialize.outputs.backend == 'true' }}
frontend: ${{ needs.initialize.outputs.frontend == 'true' }}
cli: ${{ needs.initialize.outputs.cli == 'true' }}
# TODO: remove this param after testing E2E tests invocation
e2e: true
e2e: ${{ needs.initialize.outputs.build }}
secrets:
DOTCMS_LICENSE: ${{ secrets.DOTCMS_LICENSE }}

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/cicd_2-merge-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ jobs:
postman: ${{ needs.initialize.outputs.backend == 'true' }}
frontend: ${{ needs.initialize.outputs.frontend == 'true' }}
cli: ${{ needs.initialize.outputs.cli == 'true' }}
# This will probably need to be re-evaluated, that is if it makes sense to tun E2E tests at the merge queue
# e2e: ${{ needs.initialize.outputs.build }}
secrets:
DOTCMS_LICENSE: ${{ secrets.DOTCMS_LICENSE }}
finalize:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/cicd_3-trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ jobs:
with:
run-all-tests: ${{ inputs.run-all-tests || false }}
artifact-run-id: ${{ needs.initialize.outputs.artifact-run-id }}
e2e: true
secrets:
DOTCMS_LICENSE: ${{ secrets.DOTCMS_LICENSE }}
permissions:
Expand Down

0 comments on commit 34b682f

Please sign in to comment.