Skip to content

Commit

Permalink
fix(deployment): Runtime error in CICD PR Checks due to data type inc…
Browse files Browse the repository at this point in the history
…ompatibility (#30164) (#30165)

### Proposed Changes
* This PR fixes a runtime error in the CICD PR verification phase caused
by an incorrect logical expression. The expression `${{
needs.initialize.outputs.build }}` has been updated to `${{
needs.initialize.outputs.build == 'true' }}` to ensure correct type
handling. This change explicitly compares the value to 'true', resolving
potential failures when dealing with boolean, empty, or null values.

### Additional Info
This PR resolves #30164 (Runtime error in CICD PR Checks due to
incompatible data type).
  • Loading branch information
dcolina authored Sep 27, 2024
1 parent 9909dff commit daef808
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/cicd_1-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
postman: ${{ needs.initialize.outputs.backend == 'true' }}
frontend: ${{ needs.initialize.outputs.frontend == 'true' }}
cli: ${{ needs.initialize.outputs.cli == 'true' }}
e2e: ${{ needs.initialize.outputs.build }}
e2e: ${{ needs.initialize.outputs.build == 'true' }}
secrets:
DOTCMS_LICENSE: ${{ secrets.DOTCMS_LICENSE }}

Expand Down

0 comments on commit daef808

Please sign in to comment.