Epic about PrimeNG Upgrade #29614
Merged
Epic about PrimeNG Upgrade #29614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on the storybook, I find the following issues:
|
### Parent Issue #29606 ### Additonal Info This PR is not for the master branch, but is for the **epic-primeng-upgrade** branch to break this epic into smaller PRs. ### Proposed Changes * Upgrade PrimeNg-15-lte to PrimeNg 17 --------- Co-authored-by: Nicolas Molina <[email protected]> Co-authored-by: spbolton <[email protected]> Co-authored-by: Victor Alfaro <[email protected]>
### Parent Issue #29648 ### Proposed Changes * Fix problem with breadcrumbs styles and PrimeNG v17 * Fix problem with storybook and alias signals ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable) ### Screenshots Original | Updated :-------------------------:|:-------------------------:  |   |   |   |   |   | 
### Proposed Changes * add the `p-buttonset` rules ### Screenshots Before: <img width="327" alt="image" src="https://github.com/user-attachments/assets/8dc80802-c974-4876-9288-74c76e302f59"> After: <img width="294" alt="image" src="https://github.com/user-attachments/assets/6eed9fd8-10d4-4ae5-b47a-861a4daff3c4">
### Parent Issue #29657 ### Proposed Changes * Fix error with breaking change by PrimeNg V17 upgrade > gridItem and listItem templates are deprecated and will removed in the future, use list and grid templates instead. ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable) ### Screenshots v15 | v17 :-------------------------:|:-------------------------:  |   |  DotCMS/ThemeSelector | DotCMS/ThemeSelector  |   |   | 
…9686) ### Proposed Changes * changes to support outline SplitButton styles. ### Screenshots Before <img width="621" alt="image" src="https://github.com/user-attachments/assets/b2a72f86-5a0f-490a-adbd-f7ae147362c0"> <img width="572" alt="image" src="https://github.com/user-attachments/assets/5cf27ab0-d3ce-40a4-af04-f05a8d806b97"> After <img width="595" alt="image" src="https://github.com/user-attachments/assets/b6e975c5-0cb7-49e3-b1ff-3f2f80f82dd6"> <img width="562" alt="image" src="https://github.com/user-attachments/assets/8b970e93-7970-4517-8afe-045f8491bdf5">
… change (#29704) ### Proposed Changes * remove attr `autoDisplayFirst ` since will be deprecated; we have placeholders on all the cases actually don't make any difference based on the description: `Whether to display the first item as the label if no placeholder is defined and value is null.` * adding styles to remove the outline in the dropdown label / placeholder. ### Screenshots Before <img width="382" alt="image" src="https://github.com/user-attachments/assets/b0bdaeee-b6a8-4f0a-9dff-7127bbaf7086"> After <img width="379" alt="image" src="https://github.com/user-attachments/assets/216d8416-1d9a-4276-8395-b1ef453b3eb8">
### Parent Issue #29058 ### Issues - TreeSelect has an unnecessary border. - Remove TreeSelect Clone - Fix Space ### Screenshots v15 | v17 :-------------------------:|:-------------------------:  | 
### Proposed Changes * The `justify-content` rule has been overwritten by the PrimeNG theme, but because of the [CSS layer](https://primeng.org/guides/csslayer) implemented in V17, the custom styles now take precedence.
###Parent Issue #29682 ### Proposed Changes * change 1 * change 2 ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info ** ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
nicobytes
requested review from
zJaaal,
fmontes,
hmoreras,
rjvelazco and
KevinDavilaDotCMS
…ic-primeng-upgrade
fmontes
reviewed
Aug 28, 2024
core-web/apps/dotcms-ui/src/app/portlets/dot-pages/dot-pages-store/dot-pages.store.spec.ts
Show resolved
Hide resolved
fmontes
approved these changes
Aug 28, 2024
hmoreras
approved these changes
Aug 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#29058
Objective
This is a PR to collect small PRs to upgrade from PrimeNG v15 to v17.
PRs associated