Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TTL parameters in dotParse Velocity directive #29628

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Include TTL parameters in dotParse Velocity directive #29628

merged 2 commits into from
Aug 17, 2024

Conversation

freddyDOTCMS
Copy link
Contributor

@freddyDOTCMS freddyDOTCMS commented Aug 16, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Include a second parameters in the dotParse directive to set a TTL just like the dotCache directive
  • Include methods to process something after render any Template using the dotDirective class

https://github.com/dotCMS/core/pull/29628/files#diff-5bb38e461f0bcc492aaf6c13d9e7116ed14e533c727550ecd62e63599c85ea69R136

  • Create a method to allow retrieve from cache any value before do the render of a Template, this methos is going to be define on the dotDirective class and be override on the dotParse class

https://github.com/dotCMS/core/pull/29628/files#diff-5bb38e461f0bcc492aaf6c13d9e7116ed14e533c727550ecd62e63599c85ea69R83

https://github.com/dotCMS/core/pull/29628/files#diff-046d4b8541bc8f8e5ad86fc004d0134b74c30dace321de05009be56225611d85R211

This PR fixes: #29144

@freddyDOTCMS freddyDOTCMS marked this pull request as ready for review August 16, 2024 21:40
@freddyDOTCMS
Merge branch 'master' into issue-29144-Enhance-the-#dotParse-directiv…
b96c533 
…e-to-allow-inclusion-of-a-block-cache-#dotcache-TTL
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
6 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@freddyDOTCMS freddyDOTCMS added this pull request to the merge queue Aug 16, 2024
Merged via the queue into master with commit c8f8051 Aug 17, 2024
31 checks passed
@freddyDOTCMS freddyDOTCMS deleted the issue-29144-Enhance-the-#dotParse-directive-to-allow-inclusion-of-a-block-cache-#dotcache-TTL branch August 17, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralfaro-dotcms victoralfaro-dotcms victoralfaro-dotcms approved these changes

@dsilvam dsilvam dsilvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance the #dotParse directive to allow inclusion of a block cache (#dotcache) TTL
3 participants
@freddyDOTCMS @dsilvam @victoralfaro-dotcms