Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typing errors #29630

Merged
merged 10 commits into from
Aug 19, 2024
Merged

chore: fix some typing errors #29630

merged 10 commits into from
Aug 19, 2024

Conversation

nicobytes
Copy link
Contributor

@nicobytes nicobytes commented Aug 16, 2024

Parent Issue

#29635

Proposed Changes

  • Fix some type errors
  • Fix typing error handling input event
Screenshot 2024-08-19 at 9 38 49 AM

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

@nicobytes nicobytes marked this pull request as ready for review August 16, 2024 22:26
@nicobytes nicobytes changed the title chore: fix error with strictTemplates chore: fix error private store Aug 16, 2024
@nicobytes nicobytes changed the title chore: fix error private store chore: fix some typing errors Aug 19, 2024
@nicobytes nicobytes linked an issue Aug 19, 2024 that may be closed by this pull request
@nicobytes nicobytes added this pull request to the merge queue Aug 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
### Parent Issue
#29635

### Proposed Changes
* Fix some type errors
* Fix typing error handling input event

<img width="1109" alt="Screenshot 2024-08-19 at 9 38 49 AM"
src="https://github.com/user-attachments/assets/7521e4eb-cc4b-4f93-a679-6f498fbdee73">


### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@nicobytes nicobytes added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit 600b4f3 Aug 19, 2024
18 checks passed
@nicobytes nicobytes deleted the fix-error-store branch August 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StrictTemplates: Fix type errors with inputs and event handler
3 participants