feat(edit-content) refactor to use signal store as store Edit Content #30201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
requested review from
rjvelazco,
nicobytes,
hmoreras,
zJaaal and
KevinDavilaDotCMS
oidacra
force-pushed
the
issue-30020-migration-signal-store
branch
from
daa4bc7
to
adf50ba
Compare
valentinogiardino
approved these changes
Oct 2, 2024
oidacra
force-pushed
the
issue-30020-migration-signal-store
branch
from
ee32b38
to
e8f99f0
Compare
nicobytes
previously requested changes
Oct 3, 2024
...ibs/edit-content/src/lib/components/dot-edit-content-form/dot-edit-content-form.component.ts
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/store/edit-content.store.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.spec.ts
Outdated
Show resolved
Hide resolved
core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.ts
Outdated
Show resolved
Hide resolved
hmoreras
approved these changes
Oct 3, 2024
oidacra
force-pushed
the
issue-30020-migration-signal-store
branch
from
e8f99f0
to
733a094
Compare
|
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
…#30201) ### Proposed Changes * refactor to use signal store as store Edit Content ### Checklist - [x] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info **
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
This PR fixes: #30020