chore(edit-content): Import From URL for Image Field #30295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com:dotCMS/core into 30061-image-field-import-from-url-functionality
oidacra
reviewed
Oct 9, 2024
...ds/dot-edit-content-file-field/components/dot-form-import-url/store/form-import-url.store.ts
Show resolved
Hide resolved
nicobytes
changed the title
hmoreras
reviewed
Oct 10, 2024
...ot-edit-content-file-field/components/dot-form-import-url/dot-form-import-url.component.html
Outdated
Show resolved
Hide resolved
hmoreras
approved these changes
Oct 10, 2024
oidacra
reviewed
Oct 10, 2024
...ntent/src/lib/fields/dot-edit-content-file-field/services/upload-file/upload-file.service.ts
Show resolved
Hide resolved
oidacra
reviewed
Oct 10, 2024
...ntent/src/lib/fields/dot-edit-content-file-field/services/upload-file/upload-file.service.ts
Show resolved
Hide resolved
oidacra
approved these changes
Oct 10, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
## Parent Issue #30061 ## Summary This pull request includes significant updates to the `DotFormImportUrlComponent` and its associated store, focusing on improving file upload handling and adding comprehensive unit tests. The most important changes include updating the component and store to handle accepted file types, adding abort functionality for uploads, and enhancing test coverage. ### Component and Store Enhancements: * Updated the `DotFormImportUrlComponent` to handle accepted file types and added an abort controller to manage upload cancellations. * Modified the `FormImportUrlStore` to include accepted file types in its state and added methods to initialize setup and handle file uploads with abort functionality. ### Unit Tests Enhancements: * Added comprehensive unit tests for the `DotFormImportUrlComponent`, covering initialization, form submission, and upload cancellation scenarios. * Added unit tests for the `FormImportUrlStore` to verify state initialization, setup, and file upload handling. ### Minor UI Adjustments: * Adjusted the error message and button styles to improve the user interface. ### Test Updates for File Field Component: * Updated existing tests to use the new `uploadFile` method instead of `uploadDotAsset`. ### Checklist - [x] Tests - [x] Translations - [x] Security Implications Contemplated (add notes if applicable) ### Video
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#30061
Summary
This pull request includes significant updates to the
DotFormImportUrlComponentand its associated store, focusing on improving file upload handling and adding comprehensive unit tests. The most important changes include updating the component and store to handle accepted file types, adding abort functionality for uploads, and enhancing test coverage.Component and Store Enhancements:
DotFormImportUrlComponentto handle accepted file types and added an abort controller to manage upload cancellations.FormImportUrlStoreto include accepted file types in its state and added methods to initialize setup and handle file uploads with abort functionality.Unit Tests Enhancements:
Added comprehensive unit tests for the
DotFormImportUrlComponent, covering initialization, form submission, and upload cancellation scenarios.Added unit tests for the
FormImportUrlStoreto verify state initialization, setup, and file upload handling.Minor UI Adjustments:
Test Updates for File Field Component:
uploadFilemethod instead ofuploadDotAsset.Checklist
Video
This PR fixes: #30061