-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edit-content) add language variable to wysiwyg and autodetect language code #30419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oidacra
force-pushed
the
issue-30222-support-laguage-variables-wysiwyg
branch
from
October 23, 2024 13:52
94114f9
to
5aeb6ac
Compare
oidacra
requested review from
hmoreras,
zJaaal,
rjvelazco,
valentinogiardino and
KevinDavilaDotCMS
October 23, 2024 14:08
hmoreras
approved these changes
Oct 23, 2024
nicobytes
approved these changes
Oct 23, 2024
oidacra
force-pushed
the
issue-30222-support-laguage-variables-wysiwyg
branch
from
October 23, 2024 18:12
7c39623
to
651a569
Compare
…locity code in Monaco editor
oidacra
force-pushed
the
issue-30222-support-laguage-variables-wysiwyg
branch
from
October 23, 2024 18:13
651a569
to
51eeca3
Compare
Quality Gate passedIssues Measures |
spbolton
pushed a commit
that referenced
this pull request
Nov 11, 2024
…nguage code (#30419) ### Proposed Changes * Add support to WYSIWYG to add Language Variables * Auto-detect language in code. * Add Velocity to code detection ### Checklist - [x] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info ** any additional useful context or info ** ### Screenshots https://github.com/user-attachments/assets/3f8ac8bd-e89b-471f-a669-e044b675154a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Additional Info
** any additional useful context or info **
Screenshots
CleanShot.2024-10-22.at.11.48.57.mp4
This PR fixes: #30222