#30673: Making dotAI and analytics app properties reloadable #30680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralfaro-dotcms
force-pushed
the
30673-make-dotai-analytics-config-properties-reloadable
branch
from
731cb1a
to
601ecd3
Compare
|
dsilvam
approved these changes
Nov 15, 2024
jcastro-dotcms
approved these changes
Nov 18, 2024
victoralfaro-dotcms
deleted the
30673-make-dotai-analytics-config-properties-reloadable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
System Tablesit's a good practice not to cache Config properties in final classes (instance or static) variables so they can be reloadable through such.This PR fixes: #30673