feat: allow embedding the operation result type #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
approved these changes
Feb 5, 2023
|
@n1ru4l do we expect any breaking change here? or this should not effect other libs that are using this version of typed-document-node? |
dotansimha
force-pushed
the
feat-embed-operation-type
branch
from
b6ecff7 to
b6624c5
Compare
🦋 Changeset detectedLatest commit: b6624c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@n1ru4l I rebased and added changeset. Feel free to merge (just please see my comment above) |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow tooling such as
@graphql-tools/executor-httpto infer the execution result type of aTypedDocumentand returnPromise<AsyncIterable<ExecutionResult<T>>>orPromise<ExecutionResult<T>>, which removes the need of having to do code assertions.