Upgrade GraphiQL setup, support more options #3193
Conversation
|
| }, | ||
| }, | ||
| define: { | ||
| 'process.env.NODE_ENV': '"production"', | ||
| // 'process.env.NODE_ENV': '"production"', |
There was a problem hiding this comment.
this was necessary to get the vite server to actually function locally, however I'm not sure whether or not it should be removed altogether. Thoughts?
|
The typescript failures here appear to be unrelated to my changes, though maybe they resulted from some of the version upgrades I bundled in here. Happy to try to back those out if you think that's the right course of action, or maybe somebody on your side wants to figure out how to roll forward with them. |
|
Hi @dimaMachina @saihaj, wondering if we can do what's necessary to get the GraphiQL setup upgraded within yoga. There are a lot of options and improvements I'd like to have access to, and the version in yoga is very dated. Thank you and sorry for the additional ping 🙏 |
|
Hi @bgentry Also, I would love to learn more about how you use Yoga and GraphQL in general and get any feedback you have for us on things we can improve Thanks again and we'll hopefully get this done very soon |
ardatan
force-pushed
the
bg-graphiql-options
branch
from
e440789 to
2839861
Compare
ardatan
force-pushed
the
bg-graphiql-options
branch
from
2839861 to
3b0fc6a
Compare
|
Thanks for the PR, and sorry for the late review :) Unfortunately integration tests are failing :/ |
|
Closed in favor of #3279 |
This upgrades all dependencies in the GraphiQL package. In doing so, I had to partially re-patch the
@graphiql/reactdep. It was unclear to me whether the full patch was still needed and in my testing I didn't see any need for it, but a maintainer is probably better placed to verify this.I also added support for some newer options to the graphiql plugin, such as the ability to persist headers between refreshes.