Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial example #3452

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Tutorial example #3452

merged 3 commits into from
Nov 19, 2024

Conversation

gilgardosh
Copy link
Collaborator

@gilgardosh gilgardosh commented Oct 31, 2024

New example to match the current Yoga tutorial

@gilgardosh gilgardosh self-assigned this Oct 31, 2024
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 71ad177

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Oct 31, 2024

💻 Website Preview

The latest changes are available as preview in: https://211ffe32.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Oct 31, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 525984      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 106 MB  705 kB/s
     http_req_blocked.............................: avg=1.42µs   min=952ns    med=1.27µs   max=292.39µs p(90)=1.87µs   p(95)=2.07µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=130.88µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=358.59µs min=218.66µs med=323.39µs max=15.1ms   p(90)=457.52µs p(95)=484.02µs
       { expected_response:true }.................: avg=358.59µs min=218.66µs med=323.39µs max=15.1ms   p(90)=457.52µs p(95)=484.02µs
     ✓ { mode:graphql-jit }.......................: avg=287.23µs min=218.66µs med=264.94µs max=15.1ms   p(90)=297.01µs p(95)=311.75µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=487.16µs min=394.68µs med=459.02µs max=9.45ms   p(90)=512.25µs p(95)=546.94µs
     ✓ { mode:graphql-response-cache }............: avg=337.82µs min=264.07µs med=319.31µs max=6.06ms   p(90)=351.39µs p(95)=362.94µs
     ✓ { mode:graphql }...........................: avg=370.24µs min=272.04µs med=334.39µs max=13.77ms  p(90)=396.31µs p(95)=442.84µs
     ✓ { mode:uws }...............................: avg=346.72µs min=265.93µs med=324.58µs max=9.78ms   p(90)=361.77µs p(95)=379.05µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 262992
     http_req_receiving...........................: avg=32.2µs   min=16.18µs  med=32.33µs  max=4.12ms   p(90)=37.78µs  p(95)=39.79µs 
     http_req_sending.............................: avg=7.92µs   min=5.81µs   med=7.02µs   max=308.83µs p(90)=10.48µs  p(95)=11.18µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=318.46µs min=183.17µs med=284.01µs max=14.99ms  p(90)=416.9µs  p(95)=441.13µs
     http_reqs....................................: 262992  1753.257082/s
     iteration_duration...........................: avg=565.66µs min=385.92µs med=527.81µs max=15.64ms  p(90)=668.24µs p(95)=700.51µs
     iterations...................................: 262992  1753.257082/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@gilgardosh gilgardosh marked this pull request as draft November 5, 2024 11:53
@gilgardosh gilgardosh force-pushed the tutorial-example branch 4 times, most recently from b3b07c7 to f6e5c3e Compare November 5, 2024 13:01
@gilgardosh gilgardosh marked this pull request as ready for review November 5, 2024 14:32
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be within examples/hackernews instead? Also we had integration tests for the other example. It might sense to also add them here.

@gilgardosh gilgardosh force-pushed the tutorial-example branch 6 times, most recently from 07c98e5 to a60099b Compare November 11, 2024 15:56
@gilgardosh
Copy link
Collaborator Author

@n1ru4l I ended up merging it into the hackernews example.
I intentionally split it into 2 commits:
The first one is without the final stage, second is the complete thing - as the codegen "magic" in the last tutorial step makes stuff less upfront and harder to navigate.
Maybe worth mark it as a bonus step and remove the last commit? what do you think?

@gilgardosh gilgardosh requested a review from n1ru4l November 18, 2024 10:31
@gilgardosh gilgardosh merged commit 6ff88e6 into main Nov 19, 2024
35 checks passed
@gilgardosh gilgardosh deleted the tutorial-example branch November 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants