-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New yoga website #3570
New yoga website #3570
Conversation
|
@@ -0,0 +1,8 @@ | |||
import { useMDXComponents as getDocsMDXComponents } from '@theguild/components/server'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI: I added useHiveMDXComponents
which already includes the link with underline that's fine for Neue Montreal on Safari.
{ route: '/v4', name: 'v4', children: v4PageMap }, | ||
{ route: '/v3', name: 'v3', children: v3PageMap }, | ||
{ route: '/v2', name: 'v2', children: v2PageMap }, | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: why do we need to change the page map for versions here?
Won't Nextra automatically know about these directories?
Edit: Ahh, they aren't kept on main
, right? I just noticed remote-files
. Makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nextra doesn't create pageMap
for dynamic folders for now
website/src/app/layout.tsx
Outdated
], | ||
children: ( | ||
<VersionDropdown | ||
currentVersion="Version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make it a client component that reads from pathname and displays something like v4
?
website/src/app/layout.tsx
Outdated
currentVersion="Version" | ||
chevronPosition="right" | ||
versions={[ | ||
{ label: 'Yoga 5 Docs (latest)', href: '/docs', value: '5' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.