Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New yoga website #3570

Merged
merged 111 commits into from
Jan 22, 2025
Merged

New yoga website #3570

merged 111 commits into from
Jan 22, 2025

Conversation

dimaMachina
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 5958e00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimaMachina dimaMachina marked this pull request as ready for review January 6, 2025 12:53
@dimaMachina dimaMachina marked this pull request as draft January 6, 2025 16:10
@dimaMachina dimaMachina marked this pull request as ready for review January 14, 2025 12:30
@@ -0,0 +1,8 @@
import { useMDXComponents as getDocsMDXComponents } from '@theguild/components/server';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI: I added useHiveMDXComponents which already includes the link with underline that's fine for Neue Montreal on Safari.

https://github.com/graphql-hive/console/pull/6089/files#diff-bf4047e48cd3a07968cee5d4f9e2798c62cc61d2b6c6118c3c07328cd396cea7R1

{ route: '/v4', name: 'v4', children: v4PageMap },
{ route: '/v3', name: 'v3', children: v3PageMap },
{ route: '/v2', name: 'v2', children: v2PageMap },
];
Copy link
Collaborator

@hasparus hasparus Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: why do we need to change the page map for versions here?
Won't Nextra automatically know about these directories?

Edit: Ahh, they aren't kept on main, right? I just noticed remote-files. Makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextra doesn't create pageMap for dynamic folders for now

],
children: (
<VersionDropdown
currentVersion="Version"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it a client component that reads from pathname and displays something like v4?

currentVersion="Version"
chevronPosition="right"
versions={[
{ label: 'Yoga 5 Docs (latest)', href: '/docs', value: '5' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is "latest" needed? if you think so, maybe we should have some icon?

image

@dimaMachina dimaMachina merged commit 8cfd313 into main Jan 22, 2025
28 of 29 checks passed
@dimaMachina dimaMachina deleted the new-docs branch January 22, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants