Skip to content

Commit

Permalink
Update to Node.js 20.x (#901)
Browse files Browse the repository at this point in the history
Node 18 is in maintenance mode, while 20 is in active development. We
should use 20.
  • Loading branch information
junlarsen authored May 1, 2024
1 parent f53d724 commit bd4beff
Show file tree
Hide file tree
Showing 12 changed files with 143 additions and 516 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
with:
node-version: 18.18.0
node-version: 20.12.2
cache: 'pnpm'

- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions apps/brevduen/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM public.ecr.aws/lambda/nodejs:18 AS builder
FROM public.ecr.aws/lambda/nodejs:20 AS builder

WORKDIR /usr/app
COPY apps ./apps
Expand All @@ -9,7 +9,7 @@ RUN npm i -g pnpm@8
RUN pnpm install --frozen-lockfile
RUN pnpm build:brevduen

FROM public.ecr.aws/lambda/nodejs:18 AS runner
FROM public.ecr.aws/lambda/nodejs:20 AS runner

WORKDIR ${LAMBDA_TASK_ROOT}

Expand Down
2 changes: 1 addition & 1 deletion apps/brevduen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"devDependencies": {
"@biomejs/biome": "1.6.4",
"@types/aws-lambda": "^8.10.129",
"@types/node": "18.18.13",
"@types/node": "^20.12.7",
"tsup": "^7.2.0",
"typescript": "^5.4.5"
}
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"devDependencies": {
"@biomejs/biome": "1.6.4",
"@dotkomonline/config": "workspace:^",
"@types/node": "^18.18.13",
"@types/node": "^20.12.7",
"@types/react": "^18.2.38",
"@types/react-dom": "^18.2.17",
"autoprefixer": "^10.4.16",
Expand Down
2 changes: 1 addition & 1 deletion apps/invoicification/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"devDependencies": {
"@biomejs/biome": "1.6.4",
"@dotkomonline/config": "workspace:^",
"@types/node": "^18.18.13",
"@types/node": "^20.12.7",
"@types/react": "^18.2.38",
"@types/react-dom": "^18.2.17",
"autoprefixer": "^10.4.16",
Expand Down
2 changes: 1 addition & 1 deletion apps/rif/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"devDependencies": {
"@biomejs/biome": "1.6.4",
"@dotkomonline/config": "workspace:^",
"@types/node": "^18.18.13",
"@types/node": "^20.12.7",
"@types/react": "^18.2.38",
"@types/react-dom": "^18.2.17",
"autoprefixer": "^10.4.16",
Expand Down
2 changes: 1 addition & 1 deletion apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@dotkomonline/logger": "workspace:*",
"@types/cors": "^2.8.17",
"@types/jsdom": "^21.1.6",
"@types/node": "^18.18.13",
"@types/node": "^20.12.7",
"@types/react": "^18.2.38",
"@types/react-dom": "^18.2.17",
"autoprefixer": "^10.4.16",
Expand Down
9 changes: 3 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,13 @@
],
"packageManager": "[email protected]",
"engines": {
"node": ">=18.18.0",
"pnpm": ">=8.7.6"
"node": ">=20.12.2",
"pnpm": ">=9"
},
"devDependencies": {
"dotenv-cli": "^7.3.0",
"ts-node": "^10.9.1",
"tsc-watch": "^6.0.4",
"turbo": "^1.10.16",
"turbo-ignore": "^1.10.16",
"typescript": "^5.4.5",
"vitest": "^1.3.1"
"typescript": "^5.4.5"
}
}
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@biomejs/biome": "1.6.4",
"@dotkomonline/types": "workspace:*",
"@testcontainers/postgresql": "^10.7.1",
"@types/node": "^18.18.13",
"@types/node": "^20.12.7",
"@vitest/ui": "^1.3.1",
"testcontainers": "^10.7.1",
"typescript": "^5.4.5",
Expand Down
5 changes: 4 additions & 1 deletion packages/core/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
{
"extends": "../../tsconfig.json",
"include": ["./**/*.ts"]
"include": ["./**/*.ts"],
"compilerOptions": {
"types": ["vitest/globals"]
}
}
Loading

0 comments on commit bd4beff

Please sign in to comment.