Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New doc: How to upgrade ASP.NET Core 2.0 to 2.1 #6404

Closed
Rick-Anderson opened this issue May 14, 2018 · 9 comments
Closed

New doc: How to upgrade ASP.NET Core 2.0 to 2.1 #6404

Rick-Anderson opened this issue May 14, 2018 · 9 comments
Assignees
Labels
Pri0 Urgent priority

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented May 14, 2018

URL must be https://docs.microsoft.com/en-us/aspnet/core/migration/20-to-21/?view=aspnetcore-2.1

Title Migrate from ASP.NET Core 2.0 to 2.1
See #6069 ?
Update link in

uid: aspnetcore-2.1
# What's new in ASP.NET Core 2.1

See [Migrate from ASP.NET Core 2.0 to 2.1](xref:migration/index)

See https://www.stevejgordon.co.uk/upgrading-aspnet-core-2-application-aspnet-core-2-1-preview-1 and ask Steve Gordon to review.

@Rick-Anderson
Copy link
Contributor Author

All that's in CompatibilityVersion and #6069
I'll show the new code the templates generate.

@Rick-Anderson Rick-Anderson self-assigned this May 15, 2018
@Rick-Anderson
Copy link
Contributor Author

@natemcmaster can you give me the elevator pitch on why the templates went from BuildWebHost to CreateWebHostBuilder

I'd like to add that to this migration doc.

@Rick-Anderson
Copy link
Contributor Author

@natemcmaster bonus if you can tell me why "AllowedHosts": "*" was added to appsettings.json.

@natemcmaster
Copy link
Contributor

AllowedHosts was added due to dotnet/aspnetcore#2954. @Tratcher is the expert on this one.

WebHostBuilder changes were made to make it easier to write integration tests. @javiercn's can share more.

@Rick-Anderson
Copy link
Contributor Author

Rick-Anderson commented May 26, 2018

@guardrex can you review what I say about CreateWebHostBuilder and the links I provide to your testing doc in PR #6612.

@Tratcher
Copy link
Member

Tratcher commented May 26, 2018

Nate is correct on AllowedHosts. 2.1 has a small new host filtering middleware included in CreateDefaultBuilder and setting a real host name in AllowedHosts activates it. The * is only a placeholder for discoverability.

@guardrex
Copy link
Collaborator

@javiercn
Copy link
Member

We needed to get a hold of the IWebHostBuilder for testing purposes, so we switched it to CreateWebHostBuilder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri0 Urgent priority
Projects
None yet
Development

No branches or pull requests

6 participants