Migrate from 2.0 to 2.1 #6612

Rick-Anderson · 2018-05-26T01:16:28Z

Rick-Anderson · 2018-05-26T02:28:37Z

@scottaddie do you remember how @danroth27 wanted to TOC. IIRC, he wanted the #Migration to go to this page rather than the index page - But I think this works better.

guardrex · 2018-05-26T13:55:05Z

aspnetcore/migration/20_21.md

+
+[!code-csharp[Main](20_21/sample/Program.cs?name=snippet)]
+
+The new `Main` replaces the call to `BuildWebHost` with [CreateWebHostBuilder](/dotnet/api/microsoft.aspnetcore.mvc.testing.webapplicationfactory-1.createwebhostbuilder?view=aspnetcore-2.1#Microsoft_AspNetCore_Mvc_Testing_WebApplicationFactory_1_CreateWebHostBuilder). [WebHostBuilder](https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.hosting.webhostbuilder?view=aspnetcore-2.0) was introduced to make it easier to write integration tests. For more information, see [Integration tests](xref:test/integration-tests) and  [Razor Pages unit and integration tests](xref:test/razor-pages-tests).


U can take the CreateWebHostBuilder API link down to ...

[CreateWebHostBuilder](/dotnet/api/microsoft.aspnetcore.mvc.testing.webapplicationfactory-1.createwebhostbuilder)

Instead of the concrete WebHostBuilder, describe the interface ...

[IWebHostBuilder](/dotnet/api/microsoft.aspnetcore.hosting.iwebhostbuilder)

I view the introduction of IWebHostBuilder for integration tests as an esoteric implementation detail, so I don't surface the reason for its existence or its mechanics in the topic. That may change on review, but I hope not given the length and complexity of the topic. Therefore, I recommend (at least today) that you strip the last two sentences and remove the cross-link that to the testing topics. If you want to keep it tho, I recommend it go like this ...

[IWebHostBuilder](/dotnet/api/microsoft.aspnetcore.hosting.iwebhostbuilder) is introduced to support new [integration test infrastructure](xref:test/integration-tests).

... that way it doesn't suggest that they'll get further explanation on it in the test topic.

davidfowl · 2018-05-26T14:35:26Z

aspnetcore/migration/20_21.md

+
+## Update the project file to use 2.1 versions
+
+Update the *.csproj* project file:


Why isn't there a before and after picture for the project file migration as well?

@davidfowl I added the before/after csproj files. Also added the before/after pic which I think is a distraction and we should remove. It's so lit up it doesn't tell you much.

Yeah, I don't think we need both the diff images and the before and after examples. I think the diff images can be removed.

davidfowl · 2018-05-26T14:36:56Z

aspnetcore/migration/20_21/sample/Startup.cs

+        {
+            if (env.IsDevelopment())
+            {
+                // app.UseBrowserLink();


Remove this, why is it commented out?

Tratcher · 2018-05-29T15:58:01Z

aspnetcore/migration/20_21.md

+
+The following code shows the changes to 2.1 template generated code. All changes are newly added code, except that `UseBrowserLink` has been removed:
+
+[!code-csharp[Main](20_21/sample/Startup.cs?highlight=3,4,21-26,30,45,47)]


Missing a highlight on UseHsts.

Tratcher · 2018-05-29T15:59:34Z

aspnetcore/migration/20_21.md

+* *Pages/_Layout.cshtml* moves to *Pages/Shared/_Layout.cshtml*
+* The *Layout.cshtml* file has the following changes:
+
+  * `<partial name="_CookieConsentPartial" />` is added.


Backreference to GDPR support

Tratcher · 2018-05-29T16:06:26Z

Where's the upsell 😁? This covers the mechanical conversion well, but it doesn't tell me why I should upgrade. I'd expect a short intro paragraph on the new features in 2.1 (not just the ones that required template changes), or at least a link to the 2.1 blog posts.

danroth27 · 2018-05-29T16:16:17Z

aspnetcore/migration/20_21.md

+* Change `<TargetFramework>netcoreapp2.0</TargetFramework>` to the 2.1 version, that is `<TargetFramework>netcoreapp2.1</TargetFramework>`.
+* Replace the version specified "Microsoft.AspNetCore.All"  package reference with the versionless "Microsoft.AspNetCore.App" package reference. See [Migrating from Microsoft.AspNetCore.All to Microsoft.AspNetCore.App](xref:fundamentals/metapackage#migrate) and [Microsoft.AspNetCore.App metapackage](xref:fundamentals/metapackage-app).
+* Remove all references to `<DotNetCliToolReference>` elements for "Microsoft.AspNetCore", "Microsoft.VisualStudio", and "Microsoft.EntityFrameworkCore" packages. These tools have been replaced by global tools.
+* Remove the `<DotNetCliToolReference>` elements for any "Microsoft.AspNetCore" packages. These have been replaced by global tools.


This is covered by the previous bullet.

danroth27 · 2018-05-29T16:29:49Z

aspnetcore/migration/20_21.md

+
+## Update the project file to use 2.1 versions
+
+Update the *.csproj* project file:


Yeah, I don't think we need both the diff images and the before and after examples. I think the diff images can be removed.

danroth27 · 2018-05-29T16:31:38Z

aspnetcore/migration/20_21.md

+
+This article provides an overview on migration to  ASP.NET Core 2.1. It does not contain a complete list of all changes needed to migrate to version 2.1. Some projects might require more steps depending on the options selected when the project was created and modifications made to the project.
+
+## Update the project file to use 2.1 versions


We need to add a couple of steps here:

If you switch from .All to .App you may need to add back dependencies that were removed from .App.

If you are targetting the the .NET Framework, then you will have individual package references instead of a meta package reference, which all need to be updated to 2.1.

Rick-Anderson · 2018-05-30T01:30:53Z

@danroth27 ready to merge?

danroth27

LGTM

Rick-Anderson added 2 commits May 25, 2018 15:15

WIP Migrate from 2.0 to 2.1

3152e0e

work

1ac4d5d

Rick-Anderson changed the title ~~WIP Migrate from 2.0 to 2.1~~ Migrate from 2.0 to 2.1 May 26, 2018

work

b58c300

Rick-Anderson requested a review from danroth27 May 26, 2018 02:27

Rick-Anderson added 4 commits May 25, 2018 17:54

work

34ac3be

work

ae8a847

work

760dcd1

work

e0942d8

Rick-Anderson mentioned this pull request May 26, 2018

New doc: How to upgrade ASP.NET Core 2.0 to 2.1 #6404

Closed

guardrex reviewed May 26, 2018

View reviewed changes

davidfowl reviewed May 26, 2018

View reviewed changes

Rick-Anderson added 3 commits May 26, 2018 09:20

work

1a549df

react to feedback

084242a

react to feedback

b9e11e4

Tratcher approved these changes May 29, 2018

View reviewed changes

danroth27 requested changes May 29, 2018

View reviewed changes

Rick-Anderson added 4 commits May 29, 2018 14:58

.

4051688

Merge branch 'master' into 21migrateFrom20/ra

da91c41

Update 20_21.md

e8a4b08

Update 20_21.md

7f79d1a

danroth27 approved these changes May 30, 2018

View reviewed changes

Rick-Anderson merged commit fa588a8 into master May 30, 2018

Rick-Anderson deleted the 21migrateFrom20/ra branch May 30, 2018 03:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate from 2.0 to 2.1 #6612

Migrate from 2.0 to 2.1 #6612

Rick-Anderson commented May 26, 2018 •

edited

Loading

Rick-Anderson commented May 26, 2018 •

edited

Loading

guardrex May 26, 2018 •

edited

Loading

davidfowl May 26, 2018

Rick-Anderson May 26, 2018

danroth27 May 29, 2018

davidfowl May 26, 2018

Tratcher May 29, 2018

Tratcher May 29, 2018

Tratcher commented May 29, 2018

danroth27 May 29, 2018

danroth27 May 29, 2018

danroth27 May 29, 2018

Rick-Anderson commented May 30, 2018

danroth27 left a comment


		[!code-csharp[Main](20_21/sample/Program.cs?name=snippet)]

		The new `Main` replaces the call to `BuildWebHost` with [CreateWebHostBuilder](/dotnet/api/microsoft.aspnetcore.mvc.testing.webapplicationfactory-1.createwebhostbuilder?view=aspnetcore-2.1#Microsoft_AspNetCore_Mvc_Testing_WebApplicationFactory_1_CreateWebHostBuilder). [WebHostBuilder](https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.hosting.webhostbuilder?view=aspnetcore-2.0) was introduced to make it easier to write integration tests. For more information, see [Integration tests](xref:test/integration-tests) and [Razor Pages unit and integration tests](xref:test/razor-pages-tests).


		## Update the project file to use 2.1 versions

		Update the .csproj project file:


		The following code shows the changes to 2.1 template generated code. All changes are newly added code, except that `UseBrowserLink` has been removed:

		[!code-csharp[Main](20_21/sample/Startup.cs?highlight=3,4,21-26,30,45,47)]


		This article provides an overview on migration to ASP.NET Core 2.1. It does not contain a complete list of all changes needed to migrate to version 2.1. Some projects might require more steps depending on the options selected when the project was created and modifications made to the project.

		## Update the project file to use 2.1 versions

Migrate from 2.0 to 2.1 #6612

Migrate from 2.0 to 2.1 #6612

Conversation

Rick-Anderson commented May 26, 2018 • edited Loading

Rick-Anderson commented May 26, 2018 • edited Loading

guardrex May 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tratcher commented May 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Rick-Anderson commented May 30, 2018

danroth27 left a comment

Choose a reason for hiding this comment

Rick-Anderson commented May 26, 2018 •

edited

Loading

Rick-Anderson commented May 26, 2018 •

edited

Loading

guardrex May 26, 2018 •

edited

Loading