Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 1.x content (or remove it) #9270

Closed
guardrex opened this issue Oct 27, 2018 — with docs.microsoft.com · 5 comments
Closed

Refactor 1.x content (or remove it) #9270

guardrex opened this issue Oct 27, 2018 — with docs.microsoft.com · 5 comments
Labels
Milestone

Comments

Copy link
Collaborator

guardrex commented Oct 27, 2018

While working on #9268, I noticed some problems with the 1.x versioning.

The versioning that appears for 1.x points to a 2.0 sample, so it's incorrect in the topic. See this 1.1 version ...

https://docs.microsoft.com/aspnet/core/tutorials/getting-started-with-swashbuckle?view=aspnetcore-1.1&tabs=visual-studio%2Cvisual-studio-xml#xml-comments

... scroll down a bit, and you'll see a CreateDefaultBuilder in there.

It also looks like the 1.x links to the sample provide a 2.0 project file.

cc: @scottaddie


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@dotnet-bot dotnet-bot added the Source - Docs.ms Docs Customer feedback via GitHub Issue label Oct 27, 2018
@guardrex guardrex added bug Pri0 Urgent priority and removed Source - Docs.ms Docs Customer feedback via GitHub Issue labels Oct 27, 2018
@guardrex guardrex added this to the Backlog milestone Oct 27, 2018
@scottaddie
Copy link
Member

@guardrex You're correct that the Program.cs sample displayed for 1.1 is incorrect.

@guardrex
Copy link
Collaborator Author

I would've fixed it on the spot, but I think the project file snippet situation needs work, too. Best to work it separately from the other issue, which has priority bug fixes that should go in quickly-ish.

@Rick-Anderson Rick-Anderson removed the bug label Jan 9, 2019
@Rick-Anderson Rick-Anderson added 2.2 Update Pri1 High priority, do before Pri2 and Pri3 Pri2 and removed Pri0 Urgent priority 2.2 Update Pri1 High priority, do before Pri2 and Pri3 labels Jan 18, 2019
@Rick-Anderson
Copy link
Contributor

Can't we remove the 1.x content?

@guardrex
Copy link
Collaborator Author

Earlier, we said we'd go with PDFs; but as we get closer to mid-year (June 27 2019 ... EOS for 1.x), I guess we'll be killing it more and more without going to the trouble of PDFing the 1.x bits.

@Rick-Anderson
Copy link
Contributor

Whoever updates this, check the closed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants