-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BuildWebHost to CreateWebHostBuilder (MD topics) #9268
Conversation
Updates Updates Update Tab update Repair versioning
eb0c120
to
3bc2ed6
Compare
@Tratcher U were coming to this later? ... No rush I don't think btw. Just making sure u 👀 saw this. If it's any conciliation (and it probably isn't 🙁), this was as painful for me to create as it is to try and review it. We were just discussing the complexity of a few topics that require a lot of versioning. |
We'd talked about limiting the 2.0 changes, no? Or do you still want to get this one done first? |
We had a big offline chat this morning, but there was no final, global decision. The call might be made on a doc-by-doc basis. [EDIT] We're going to chop the 1.x content into a PDF for Web Host and Kestrel. The updates are done on the next commit. We just need to wait for the PDFs to be posted. |
Versioning update
55fb913
to
fb0e277
Compare
@ChrisSfanos has placed the 1.1 files ... the 1.1 PDF links work. (Thanks Chris!) This is ready for a look. No rush, of course ... whenever u get around to it. |
uid: fundamentals/host/web-host | ||
--- | ||
# ASP.NET Core Web Host | ||
|
||
By [Luke Latham](https://github.com/guardrex) | ||
|
||
For the 1.1 version of this topic, download [ASP.NET Core Web Host (version 1.1, PDF)](https://webpifeed.blob.core.windows.net/webpifeed/Partners/Web-Host_1.1.pdf). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about 2.0? Are you only including 1.1 here because it's still supported for a few more months?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ... with 1.x supported until June, my understanding is that the 1.1 coverage in the PDF is sufficient to tide us over to EOL. Since 2.0 is unsupported, my understanding is that it can be dropped now.
Although the 1.1 topic coverage is provided in the PDF, it remains covered in the API browser for those who require it at least until June, possibly even after June.
We'll get the approval from APEX before we merge this just to make sure.
@Tratcher 2.0 is out of support. We'll move this 1.1 content to pdf/archive. We're going to have a meeting on archiving content to decide the .NET and ASP.NET policy going forward. |
Fixes #6091
@Rick-Anderson @scottaddie I found some minor errors in some of the topics while working on this issue. They mostly pertain to the 2.0 release, which probably explains why they haven't been flagged by anyone. We have a 😵 number of versioning sections required to address the framework churn in a few topics. This situation makes working on these topics difficult. Version 3.0 may even overlap with 1.x, adding to the totals shown in the table.
[EDIT] Build warning ... need a tip ...
[EDIT] Moved the bit about Swashbuckle 1.x versioning to a new issue: #9270