Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss absence of HTTP/2 request rate limit features #9511

Merged
merged 8 commits into from
Nov 8, 2018

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Nov 8, 2018

No description provided.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halter73

This bit (Line 267) ...

The minimum rate scenarios are only available for HTTP/1.x requests. Modifying rate limits per request isn't supported for HTTP/2 requests due to multiplexing. Server-wide rate limits apply to both HTTP/1.x and HTTP/2 requests.

... might be confusing. Boils down to: Limits per request aren't supported for HTTP/2, but server-wide limits apply to HTTP/2.

Can the "server-wide limits" be explained out a little more. Can it be contrasted a bit more (more context) with the per-request limits that are shown/set in the code example?

For the other changes, let me know if I went sideways on those commits.

@halter73
Copy link
Member Author

halter73 commented Nov 8, 2018

@guardrex Should I merge this?

@guardrex
Copy link
Collaborator

guardrex commented Nov 8, 2018

@halter73 up to you.

If you want Scott+Tom to 👁️ it, they'll be back on by tomorrow AM.

Otherwise, merge away 🚢dis

@halter73 halter73 merged commit 4307e31 into master Nov 8, 2018
@delete-merged-branch delete-merged-branch bot deleted the halter73/http2-rate branch November 8, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants