-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss absence of HTTP/2 request rate limit features #9511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit (Line 267) ...
The minimum rate scenarios are only available for HTTP/1.x requests. Modifying rate limits per request isn't supported for HTTP/2 requests due to multiplexing. Server-wide rate limits apply to both HTTP/1.x and HTTP/2 requests.
... might be confusing. Boils down to: Limits per request aren't supported for HTTP/2, but server-wide limits apply to HTTP/2.
Can the "server-wide limits" be explained out a little more. Can it be contrasted a bit more (more context) with the per-request limits that are shown/set in the code example?
For the other changes, let me know if I went sideways on those commits.
@guardrex Should I merge this? |
@halter73 up to you. If you want Scott+Tom to 👁️ it, they'll be back on by tomorrow AM. Otherwise, merge away 🚢dis |
No description provided.