Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OData tutorial #12108

Closed
wants to merge 34 commits into from
Closed

OData tutorial #12108

wants to merge 34 commits into from

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Apr 22, 2019

@Rick-Anderson Rick-Anderson mentioned this pull request Apr 22, 2019
@Rick-Anderson Rick-Anderson changed the title Ra/o data WIP Ra/o data Apr 22, 2019
@Rick-Anderson
Copy link
Contributor Author

@FIVIL can you help me with this?

    app.UseMvc(routeBuilder =>
    {
        routeBuilder.EnableDependencyInjection();
        routeBuilder.Select().OrderBy().Filter();
    });

The preceding code:

  • Enables DI for the route builder.
  • Enables select, order by, and filtering to the route builder.

@Rick-Anderson Rick-Anderson changed the title WIP Ra/o data OData tutorial Apr 23, 2019
@Rick-Anderson Rick-Anderson removed the PU label Apr 23, 2019
@FIVIL
Copy link
Contributor

FIVIL commented Apr 23, 2019

@Rick-Anderson
sure, what should i do to help you?

@Rick-Anderson
Copy link
Contributor Author

After showing the following code

    app.UseMvc(routeBuilder =>
    {
        routeBuilder.EnableDependencyInjection();
        routeBuilder.Select().OrderBy().Filter();
    });

I added this to the doc. Is that correct? Can you suggest better?

The preceding code:

  • Enables DI for the route builder.
  • Enables select, order by, and filtering to the route builder.

@Rick-Anderson Rick-Anderson added PU and removed Security-PU Must be reviewed by product unit security. labels Apr 26, 2019
@Rick-Anderson Rick-Anderson changed the title OData tutorial WIP: OData tutorial May 6, 2019
@Rick-Anderson Rick-Anderson removed the PU label May 6, 2019
@Rick-Anderson Rick-Anderson changed the title WIP: OData tutorial OData tutorial May 6, 2019
@Rick-Anderson Rick-Anderson removed the PU label May 6, 2019
@Rick-Anderson
Copy link
Contributor Author

@hassanhabib please review

@FIVIL
Copy link
Contributor

FIVIL commented May 25, 2019

Hi, i was wondering when this gets merged and if there is anything else i can help with?
@Rick-Anderson

@Rick-Anderson
Copy link
Contributor Author

@FIVIL I'm waiting for the product unit to review this. Hopefully in the next couple of week. I really appreciate your help on this.

@FIVIL
Copy link
Contributor

FIVIL commented May 25, 2019

@Rick-Anderson Sure, i see
thank you

@Rick-Anderson
Copy link
Contributor Author

@danroth27 should I delete these two OData articles?

@Rick-Anderson
Copy link
Contributor Author

@danroth27 should I delete these two OData PR's? This and #12150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odata Documentation
2 participants