Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial samples #15924

Merged
merged 17 commits into from
Nov 30, 2019
Merged

Update tutorial samples #15924

merged 17 commits into from
Nov 30, 2019

Conversation

eslam-fakhry
Copy link
Contributor

@eslam-fakhry eslam-fakhry commented Nov 29, 2019

Fixes #13232
Update "Add, download, and delete custom user data to Identity in an ASP.NET Core project" tutorial to use dotnet3.0

[EDIT by guardrex to add the internal review link]

Internal Review Link

@Rick-Anderson
Copy link
Contributor

@eslam-fakhry unfortunately we can't remove any prior versions. We usually do the following to add a new version

::: moniker range=">= aspnetcore-3.0"
// copy 2.2 version here, then update
::: moniker-end

::: moniker range="< aspnetcore-3.0"
previous version
::: moniker-end

@eslam-fakhry
Copy link
Contributor Author

@Rick-Anderson Updated the pull request

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @eslam-fakhry! 🎸 We all thank you for helping.

You may already know this: If you flip this over to the diff, you can add all of my suggestions to one batch and then commit the single batch of changes all at once.

Remove extra spaces

Co-Authored-By: Luke Latham <[email protected]>
@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Nov 30, 2019

@eslam-fakhry can you fix the merge conflicts in aspnetcore/security/authentication/add-user-data/sample-2.2/Areas/Identity/Pages/Account/Manage/Index.cshtml ?

@guardrex
Copy link
Collaborator

guardrex commented Nov 30, 2019

Thanks for doing all of this work 😅. I'll note this PR on the tracking issue at #5495.

@guardrex
Copy link
Collaborator

guardrex commented Nov 30, 2019

I'll go ahead and sign-off. Some of the lines might be too long if those lines are used in the topic ... the long ones might just be code that isn't shown tho.

I'll add the internal tracking link to your opening comment. That will indicate if there are any horizontal scrollbars.

Thanks again for all of your hard work on this. I realize it's a lot, but this topic+sample will be easy to work with now (e.g., 3.1 ... coming soon!) ... thanks to YOU! 🎸

@Rick-Anderson
Copy link
Contributor

Lines look good. Thanks @eslam-fakhry

@Rick-Anderson Rick-Anderson merged commit c6cf4a2 into dotnet:master Nov 30, 2019
@eslam-fakhry eslam-fakhry deleted the update-tutorial-samples branch December 1, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 3.0 Add, download, and delete custom user data to Identity
3 participants