Health Checks sample 3.1 updates #16204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Many thanks for this, @guardrex |
rynowak
reviewed
Dec 16, 2019
aspnetcore/host-and-deploy/health-checks/samples/3.x/HealthChecksSample/CustomWriterStartup.cs
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Dec 16, 2019
aspnetcore/host-and-deploy/health-checks/samples/3.x/HealthChecksSample/CustomWriterStartup.cs
Outdated
Show resolved
Hide resolved
rynowak
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5495
Addresses #15473
Internal Review Topic
System.Text.Jsonapproach in here but also retain the existingNewtonsoft.Jsonapproach. A directive in the file makes it easy for the dev to switch back and forth.System.Text.Jsonapproach: I couldn't getWriteNumberto work with a directly casted object ((Decimal)item.Value). I ended up performing the cast on a separate line with (Convert.ToDecimal) to make it happy.cc: @lol768