Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Custom Model Binding to 2.1. #16364

Merged
merged 3 commits into from
Jan 1, 2020
Merged

Update Custom Model Binding to 2.1. #16364

merged 3 commits into from
Jan 1, 2020

Conversation

serpent5
Copy link
Contributor

@serpent5 serpent5 commented Jan 1, 2020

Addresses #16319.
Fixes #16367

@Rick-Anderson Rick-Anderson merged commit 48c7a8f into dotnet:master Jan 1, 2020
@Rick-Anderson
Copy link
Contributor

@serpent5 nice work, thanks!

@serpent5 serpent5 deleted the serpent5-16319 branch January 2, 2020 20:02
@serpent5
Copy link
Contributor Author

serpent5 commented Jan 2, 2020

@guardrex I think this affects #5495. I'm going to look at the linked issues next and then do a 3.1 update. I dunno if you want to wait until then before updating the sample-tracker. I'm just putting it on your radar for when you're back from working through your holidays being OOF. 😄

@guardrex
Copy link
Collaborator

guardrex commented Jan 2, 2020

Thanks @serpent5 ... Since I'm not cross-linking to the PRs, I'll just update it in the tracking issue to 3.1 now. Well ... "now" = "Monday" 😄 lol ... I'm savoring my last two PTO days before 🏃 in January.

@serpent5
Copy link
Contributor Author

serpent5 commented Jan 2, 2020

I'm savoring my last two PTO days before 🏃 in January.

Glad to hear it. You guys work too hard but what you do is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1 UPDATE Model binding
3 participants