Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Model topic+sample update #21977

Merged
merged 8 commits into from
Apr 5, 2021
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Apr 4, 2021

Fixes #21971
Addresses #5495

Internal Review Topic

Thanks @babula38! 🚀 ... We'll see if Rick is ok with a single 3.1 sample because the text is version agnostic AFAICT. I ran the upgraded app locally, and its demos seem to perform ok.

Rick, I didn't perform a full line-by-line edit due to time constraints 🏃😅. I just touched up the future tense and dropped a few stray spaces at the ends of paragraphs.

UPDATE: ... but I dropped in the API doc cross-links and fixed other nits and whatnots ... did some loc work along the way. There are a couple of API things that don't seem to exist any longer. I don't mean the internal things that don't show up in API docs. I'm referring to ...

Finally, I updated the headings. I elevated the H3s under conventions to surface them in the sidebar ToC. I think that makes it a little easier to find a specific convention scenario.

Again tho, I didn't perform a complete UE pass. On Monday morning, I'll hit it one last time. May as well ... I went this far with it. 😁

@guardrex guardrex closed this Apr 4, 2021
@guardrex guardrex reopened this Apr 4, 2021
@guardrex guardrex changed the title App Model topic sample update App Model topic+sample update Apr 4, 2021
Copy link
Contributor

@Rick-Anderson Rick-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work. You even cleaned up the writing.

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 4, 2021

Cat got me up at 3:30am❗ Rotten 😼❗ Nothing else to do at that hour.

@guardrex
Copy link
Collaborator Author

guardrex commented Apr 4, 2021

I'm going to read and sweep this one last time on Monday morning. I doubt anyone will get back to it for a long time, so it's probably worth a last look before merging.

For example, I need to do something about ...

  • ActionContext.ActionDescriptor.Properties ... not sure where that is or if it went away at some point ... or it was never right. It might mean to say ActionContext.ActionDescriptor properties ("properties" not code-fenced). Cross-reference: https://docs.microsoft.com/dotnet/api/microsoft.aspnetcore.mvc.actioncontext.actiondescriptor Resolved.
  • Can't find WebApiApplicationModelConvention. I need to go an API hunt. Won't bother. The shim was dropped at 3.0, so I'll version this section, and it will drop when 2.x drops from the docs.

@guardrex guardrex merged commit de6d29a into main Apr 5, 2021
@guardrex guardrex deleted the guardrex/app-model-sample-update branch April 5, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why samples still using .net version "1.0.0-preview2-003131"
2 participants