Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor movie tutorial QuickGrid styling #34227

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Nov 27, 2024

Fixes #34218

  • I'll place the new section at the end. That way, existing images don't require updates for taller rows.
  • Going with five items per page.
  • The sample apps were updated on Update movie dB tutorial sample apps blazor-samples#399.
  • I'm making some improvements to what we placed on the earlier PR in the QuickGrid article. I think we should show the QG wrapped. I'd like to head off any possibility of issues being opened on that point, which is buried in the text of our earlier PR. However, I do use a much shorter QG example (diff) to demo it. Also, I'm splitting that out into its own section and making it clear that you're styling all rows with the approach that happens to include empty rows.

Do you want to further scope the styles to the QG using its Class property?


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/components/quickgrid.md aspnetcore/blazor/components/quickgrid
aspnetcore/blazor/tutorials/movie-database-app/part-8.md aspnetcore/blazor/tutorials/movie-database-app/part-8

@guardrex guardrex marked this pull request as ready for review November 27, 2024 12:57
@guardrex guardrex requested a review from danroth27 November 27, 2024 13:16
@guardrex guardrex self-assigned this Nov 27, 2024
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guardrex guardrex merged commit eebdeab into main Dec 3, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-movie-db-style-qg branch December 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor movie dB tutorial Paginator updates
2 participants