[WIP] Fix property assignment in primitives example #6355
Conversation
…tive and strange variable assignment.
|
I didn't realize that github would squash any commit into my personal repository into any pull requests so this commit now has an unrelated commit included which makes webcache compilable. The second commit fixes #6299 comilation. |
|
Hello @user135711! Thanks for submitting this. Would you mind removing the changes for the WebCache sample from this? We wouldn't want both samples updated on the same PR, and we can't take a PR for the WebCache sample at this time. For one thing, we can't upgrade it to 2.1 until 2.1 RTM. Also, it's due for a significant overhaul when it is upgraded that will go beyond just making it run under 2.1. We're tracking the work for it on #5495. |
|
RE: The ChangeTokens updates The changes proposed require matching changes to the topic's text for the |
guardrex
changed the title
|
@guardrex That's a good point, thanks... |
|
If you prefer that this just be taken into account for the Change Tokens 2.1 update, I recommend just opening an issue referencing this, then I'll add a note to the tracking issue for it. |
|
Alternatively, feel free to go ahead with a PR on the Change Tokens topic+sample with these changes now, and I'll ping engineering to take a look. |
|
@guardrex Shrug, if you're doing it anyway, I'll just let you update them at once. I do have some suggestions for the web cache update that I'll post directly to the issue so you'll consider including it and save me some time if you do it. |
|
ok ... sounds good. |
Fixed a bug where CurrentState is assigned the wrong value on each invocation followed by being assigned the correct value in index. Also fixed an np completeness inefficiency by passing a lamda instead of a method group since I was editing the line, and used a non primitive state object so that the value is passed by reference to reflect the current state. For np explanation see
hereand
here