Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 10, 2025

This PR add docs about breaking change that introduced by PR #2737.

After PR #2737 is merged.
It need to explicitly specify following settings to preserve old behaviors.

<BenchmarkDotNetTargetPlatform>all</BenchmarkDotNetTargetPlatform>

> Use the following settings when running the benchmark binary on multiple platforms.
>
> ```xml
> <BenchmarkDotNetTargetPlatform>all</BenchmarkDotNetTargetPlatform>
Copy link
Collaborator

@timcassell timcassell Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it support specifying an exact platform? If not, it would be a good future improvement.

[Edit] Just checked, looks like it does, either by RuntimeIdentifier or BenchmarkDotNetTargetPlatform. It would be good to document it.

@timcassell
Copy link
Collaborator

I would move it to under Requirements where it already specifies csproj properties.

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filzrev Can you address the comments?

@filzrev
Copy link
Contributor Author

filzrev commented Oct 31, 2025

I've update following changes

  • Apply Suggested change
  • Move Note content under Requirements section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants