Skip to content

use least supported framework #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

use least supported framework #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Bruce/Bruce.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0-windows</TargetFramework>
<RootNamespace>Kerberos.NET.CommandLine</RootNamespace>

<PackAsTool>true</PackAsTool>
Expand Down Expand Up @@ -41,4 +41,10 @@
<ProjectReference Include="..\Samples\KerbDumpCore\KerbDumpCore.csproj" />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

referencing "samples" project outside the sample dir looks weird

</ItemGroup>

<Target Name="RemoveTargetPlatformIdBeforePackingTool" BeforeTargets="_PackToolValidation">
<PropertyGroup>
<TargetPlatformIdentifier />
</PropertyGroup>
</Target>

</Project>
2 changes: 1 addition & 1 deletion Samples/KerbDumpCore/KerbDumpCore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Library</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0-windows</TargetFramework>
<UseWindowsForms>true</UseWindowsForms>
Copy link
Author

@kasperk81 kasperk81 Aug 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KerbDumpCore.csproj
<OutputType>Library</OutputType>

"core library" project shouldn't have dependency on windows forms. all its dependents are tied to windows


<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Expand Down
2 changes: 1 addition & 1 deletion Samples/KerberosClientApp/KerberosClientApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Samples/KerberosKdcHostApp/KerberosKdcHostApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Tests/Benchmark.Kerberos.NET/Benchmark.Kerberos.NET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net5.0-windows</TargetFramework>
<TargetFramework>net6.0-windows</TargetFramework>
<ApplicationManifest>app.manifest</ApplicationManifest>

<DebugType>pdbonly</DebugType>
Expand Down
2 changes: 1 addition & 1 deletion Tests/Tests.Kerberos.NET/Tests.Kerberos.NET.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>net6.0-windows</TargetFramework>

<DebugType>Full</DebugType>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
26 changes: 8 additions & 18 deletions build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@ stages:
vmImage: windows-latest

variables:
BuildConfiguration: Release
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true

steps:
- task: UseDotNet@2
displayName: 'Use .NET Core SDK 3.1.x'
displayName: 'Use .NET SDK'
inputs:
version: 5.x
version: 6.x
performMultiLevelLookup: true

- task: DotNetCoreCLI@2
Expand All @@ -36,29 +35,20 @@ stages:
- script: nbgv cloud
displayName: Set Version

- task: MSBuild@1
displayName: 'Build solution Kerberos.NET.sln'
- task: DotNetCoreCLI@2
displayName: 'Build and pack solution Kerberos.NET.sln'
inputs:
solution: Kerberos.NET.sln
configuration: $(BuildConfiguration)
msbuildArguments: /restore /p:CreatePackage=true
maximumCpuCount: true
command: 'custom'
custom: 'pack'
arguments: Kerberos.NET.sln -c Release --verbosity minimal

# - task: DotNetCoreCLI@2
# inputs:
# command: test
# projects: Tests/**/*.csproj
# arguments: -c $(BuildConfiguration) --no-build --no-restore --settings CodeCoverage.runsettings --collect:"XPlat Code Coverage"
# arguments: -c Release --no-build --no-restore --settings CodeCoverage.runsettings --collect:"XPlat Code Coverage"
# displayName: Run Unit Tests

- task: DotNetCoreCLI@2
inputs:
command: 'pack'
packagesToPack: './Bruce/Bruce.csproj'
nobuild: true
outputDir: $(Build.ArtifactStagingDirectory)
displayName: Pack Bruce tool

- task: PublishBuildArtifacts@1
inputs:
PathtoPublish: '$(Build.ArtifactStagingDirectory)'
Expand Down