-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for hosting extensions #1653
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,19 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion we should call this project "MQTTnet.Extensions.Hosting" to fit the other extensions (The Asp library was introduced before the naming pattern was established).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YAJeff Ping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Sorry. I have made those changes internally. Sorry. Been traveling for work. Will check in. There were other changes I've added to make things a little more solid/sound. Will have completed by the end of the weekend.
@YAJeff Please agree to the Contributor License. Then I will merge this PR. |
@dotnet-policy-service agree company="CARIAD Inc" |
@dotnet-policy-service agree company="CARIAD Inc" |
@chkr1011 the CLA check has passed, can this move forward? |
@kallayj I applied the code style and moved the tests a little around to get the code compiling. There are still some warnings left and some new properties are not even used. Please let me know when the code is finished so that I can review it. |
@chkr1011 I addressed the nullable reference type warnings. Where are you seeing unused properties? |
Please see "MqttServerHostingOptions.WebSocketRoute". It is set but never read. Same for "WebSocketAuthenticationCallback". |
@chkr1011 I removed those properties. |
With this change, the MQTTnet server can be hosted using Microsoft.Extensions.Hosting library, rather than full ASP.net core SDK.