fix(server): at-least-once messages received during subscription must… #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marve
force-pushed
the
fix-at-least-once-delivery
branch
2 times, most recently
from
3989e91
to
db29350
Compare
chkr1011
reviewed
May 4, 2024
marve
force-pushed
the
fix-at-least-once-delivery
branch
from
a8d9fbd
to
3365bf2
Compare
chkr1011
reviewed
May 9, 2024
| var atLeastOnceSubscriptionResults = new List<CreateSubscriptionResult>(); | ||
|
|
||
| IList<MqttApplicationMessage> retainedApplicationMessages = null; | ||
| if (subscribePacket.TopicFilters.Any(f => f.QualityOfServiceLevel != MqttQualityOfServiceLevel.AtLeastOnce)) |
There was a problem hiding this comment.
Why is this only relevant for at least once QoS? Isn't this also beneficial for QoS 0 and 2?
Or are you fixing a specific issue in your project here?
There was a problem hiding this comment.
Good question. The project wherein we discovered this bug uses solely AtLeastOnce. But I think you're right that it may fix potential issues with AtMostOnce and ExactlyOnce as well.
There was a problem hiding this comment.
@chkr1011 Is this PR sufficient as-is or are you requesting that I make changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… be delivered