Performance improvement for AttributeValueHolder delegate #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreamescaper
force-pushed
the
fix_equality_for_attributeValueHolder
branch
from
6e9efb3
to
2047fd3
Compare
Eilon
reviewed
May 27, 2022
| /// <summary> | ||
| /// The only purpose of this method it to use it as delegate parameter. | ||
| /// </summary> | ||
| public static object This(this object @this) => @this; |
There was a problem hiding this comment.
😢 . I'll merge this for now but I think we'll want to have a different approach, such as a regular static method. I know it's internal, and I know it's in a different namespace. But for those reasons I think this might as well be a regular static method.
There was a problem hiding this comment.
Filed #448 to think about this more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on CollectionView I realized, that our approach with AttributeValueHolder approach has an issue - created delegates are not considered equal for same value, therefore Blazor considers those attribute values as changed on each component update.
I've created an extension method This, which simply returns 'this' parameter, and create a delegate from method parameter. Delegates created in such way are considered equal for same objects, and Blazor does not re-render same attributes over and over again, yuy!
It also resolves some issues with infinite loops with binded values.