-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding WIC (WindowsCodecs) support #1674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you worked out BuildTools pretty quick! Just a few small comments, I went through 50 of the 200+ generated files and didn't see anything too objectionable, so no complaints there beyond the below.
Thank you so much in advance for your contribution!
src/Microsoft/Silk.NET.Direct2D/WindowsCodecs/WindowsCodecs.gen.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes about tag prefix removal.
PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brill, thanks (and thank you for the helpfully small commit increments and the notes).
Just one more thing that you'll hate me for not pointing out the first time around :P
src/Microsoft/Silk.NET.Direct2D/WindowsCodecs/Structs/Rect.gen.cs
Outdated
Show resolved
Hide resolved
It seems that we still need to introduce the support for Those types are located in oaidl.h and ocidl.h. Is there any way to only include the types we actually need without introducing the whole bunch of unnecessary dependencies? |
Summary of the PR
Adding support for WIC.
I would like to avoid introducing codegen dependency on
IPropertyBag2
,tagPROPVARIANT
andtagPROPBAG2
as they are legacy types used by Internet Explorer, so I added type mappings for them:IPropertyBag2
->IUnknown
tagPROPVARIANT
->void
tagPROPBAG2
->void
Related issues, Discord discussions, or proposals
Closes #813
Further Comments
Should we remove the
Tag
prefix for alltag{*}
types?