Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Contributor experience improvements #2405

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Dec 30, 2024

  • Adds a basic for-contributors getting started README for building the repo, detailing what you need to get started. Closes Create building-from-source.md #2403 which also does the same.
  • Adds a "best effort" attempt to resolve native binaries when used as a ProjectReference.
  • Adds the ability to disable building for Android/iOS by adding properties to Directory.Build.props which are then used when setting TargetFrameworks

Copy link
Contributor

Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains /build-native SDL. These libraries won't be rebuilt without this being specified. If you believe this is in error, then please write a comment explaining why and ignore this suggestion. This comment will be automatically updated if rectified.

@Perksey
Copy link
Member Author

Perksey commented Dec 30, 2024

The PR check is triggering because I've modified the native project to not include an Android build if disabled. This does not warrant a rebuild.

@Perksey Perksey marked this pull request as ready for review December 30, 2024 19:10
@Perksey Perksey requested a review from a team as a code owner December 30, 2024 19:10
@Perksey
Copy link
Member Author

Perksey commented Dec 30, 2024

@curin Ready for review.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

File Coverage
All files 3%

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 46f571d

@Perksey
Copy link
Member Author

Perksey commented Dec 30, 2024

@joskuijpers hopefully this helps? PTAL

@joskuijpers
Copy link
Contributor

Good changes! Playground now runs without SDL DLL issues, and the contributor document was very useful too.

@Perksey Perksey enabled auto-merge (squash) December 31, 2024 13:49
@Perksey Perksey merged commit d7858d8 into develop/3.0 Dec 31, 2024
19 checks passed
@Perksey Perksey deleted the hotfix/checkout-experience-improvements branch December 31, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants