Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sni version override for testing #3184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Feb 26, 2025

When we make changes to SNI, it's important to test the changes in combination with MDS to avoid regressions. This PR adds the ability to trigger a pipeline run with an overridden SNI version pulled from the internal validation feed in ADO. This functionality is only available to pipeline runs within the ADO.Net project in ADO. Pipeline runs within the public project do not have access to the internal feed and will fail if an override version is set.

Proof that runs fail in public pipelines when sni override is set:
Project: https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109913&view=results
Package: https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109914&view=results

@mdaigle mdaigle changed the title Allow sni override for testing Allow sni version override for testing Feb 27, 2025
@mdaigle mdaigle marked this pull request as ready for review February 27, 2025 16:42
@mdaigle mdaigle requested a review from a team February 27, 2025 16:42
@mdaigle mdaigle force-pushed the dev/mdaigle/testing-sni-override branch from bf93c4d to 0d228f2 Compare February 27, 2025 17:06
Copy link

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (17cb0b0) to head (2702322).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   72.96%   72.80%   -0.16%     
==========================================
  Files         283      285       +2     
  Lines       58997    59137     +140     
==========================================
+ Hits        43048    43057       +9     
- Misses      15949    16080     +131     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.53% <ø> (-0.20%) ⬇️
netfx 71.15% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you and I should have a bit of a conversation about when and how the handful of components need to be tested together (MDS, SNI, AKV, MSS, ETC, WTF, BBQ). I want to get a better idea what depends on what and how the pipelines should be constructed to handle those situations. It's nothing that needs to block this specific PR, but since I think we will want to rebuild this pipeline as part of other engineering goals, I think we'll want to discuss it at some point.

displayName: |
The specific SNI test version is pulled from this feed
type: string
default: https://sqlclientdrivers.pkgs.visualstudio.com/ADO.Net/_packaging/SNIValidation/nuget/v3/index.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After spending so much time on the AKV pipeline, I've got a lot of preferences about style for pipeline yaml. On the one hand, I could lay it all out in this PR and make things annoying. On the other hand, I anticipate rewriting this pipeline as well, and we can hold off on stylistic changes until then. Which would you prefer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're ok with waiting, I'd prefer that. I don't anticipate this to be a long term solution. I had other approaches in mind to facilitate SNI testing, but they were blocked on this pipeline migrating to onebranch. My idea was to keep this small and easily removable.

I'd also be happy to standardize on an IDE and formatter for yaml. Raw yaml editing is not the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants