Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64 is now upstream Debian architecture #14329

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

dkurt
Copy link
Contributor

@dkurt dkurt commented Dec 29, 2023

move dotnet/runtime#96349

https://wiki.debian.org/RISC-V#Package_repository

sudo ./eng/common/cross/build-rootfs.sh riscv64 sid --rootfsdir ./riscv64-rootfs

To double check:

@dkurt
Copy link
Contributor Author

dkurt commented Dec 29, 2023

@am11, please review

@am11
Copy link
Member

am11 commented Dec 29, 2023

@dkurt, looks good, thanks!

I tested it in dotnet prerequisites docker image and getting the following error:

$ docker run --rm -it mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-riscv64
$ git clone https://github.com/dkurt/arcade -b dkurt/update_riscv64_rootfs
$ cd arcade
$ ./eng/common/cross/build-rootfs.sh riscv64 sid --rootfsdir ./riscv64-rootfs
W: Cannot check Release signature; keyring file not available /usr/share/keyrings/debian-archive-keyring.gpg
E: Keyring-based check was requested; aborting accordingly

Looks like we will also need to update https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/b9b1ed5784f888a400d32dcec7f4d4978e703c83/src/ubuntu/22.04/crossdeps/Dockerfile#L53. Could you take a look what needs updating there? Otherwise, the next build will fail in that repo if we merge this.

It may not be obvious how that repository builds, but for local testing, we can use pwsh build.ps1 -DockerfilePath "*ubuntu/22.04/cross/riscv64*" on linux/osx/win machines with powershell and docker installed. You can also leave the testing for CI (which runs when we ope the PR in that repo).

@dkurt dkurt force-pushed the dkurt/update_riscv64_rootfs branch from 76934cf to 7204b6b Compare December 29, 2023 15:07
@dkurt
Copy link
Contributor Author

dkurt commented Dec 29, 2023

@am11, thanks, with dotnet/dotnet-buildtools-prereqs-docker#945 it's working.

@akoeplinger akoeplinger merged commit 1eb4fd5 into dotnet:main Jan 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants