[release/8.0] Disambiguate type names by containing assembly in WellKnownTypes

[github-actions]

Backport of #50969 to release/8.0

/cc @captainsafia

Description

ASP.NET Core's analyzer implementations use a well-known type cache to store TypeSymbols associated with key types in the ASP.NET Core space. The implementation of this cache currently uses Roslyn's GetTypeByMetadataName to resolve the type symbol from the current compilation by its name. The behavior of this API is such that it throws if it encounters two types with the same fully-qualified name in different assemblies.

This has posed a problem for certain types like IEndpointRouteBuilderExtensions which are defined in the same namespace in both ASP.NET Core and 3rd-party packages like AspNetCore.HealthChecksUI and HotChocolate.

To resolve this issue, we resolve all types with a given name in the users compilation but filter by containing assemblies under the Microsoft.*and System.* assembly names.

Closes #50836

Customer Impact

When users try to build or edit projects in Visual Studio that contain references to impacted packages (like AspNetCore.HealthChecksUI) they will encounter unhandled exceptions. Customers can workaround this by manually disabling analyzers that ship as part of the ASP.NET Core runtime and target Minimal APIs.

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

This change is low-risk given that (a) the affected code does not affect app's runtime behavior and (b) existing workarounds are still viable if users run into issues with this fix.

Verification

• Manual (required)
• Automated

[ghost]

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

[ghost]

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

[ghost]

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.