[DotnetTrace][Tests] Add functional tests validating Collect output #5581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahfalk
previously approved these changes
Oct 2, 2025
noahfalk
reviewed
Oct 2, 2025
noahfalk
reviewed
Oct 3, 2025
mdh1418
force-pushed
the
add_dotnet_trace_functional_tests
branch
from
51c7ecd to
d14f673
Compare
\n is handled differently by Windows and non-Windows consoles Simplify by emitting a newline instead.
|
I don't see how the test failure is related, created #5588 but will rerun the test just to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplements #5570 per #5570 (review)