Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Doc comment <code> block is not rendered correctly #10390

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 13, 2024

This PR intended to fix issue #10385

What's changed on this PR

  1. Modify XmlComment::ResolveCode method.
    And add empty newline before <code> tag.
  2. Add unit test code to XmlCommentUnitTest.cs
  3. Modify related unit test code. (Add newline to expected string )

Other Changes

@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Dec 4, 2024
@filzrev filzrev force-pushed the fix-issue-10385 branch 2 times, most recently from 8527322 to bd15b02 Compare December 10, 2024 10:47
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.40%. Comparing base (fe673ec) to head (a65207a).
Report is 494 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10390      +/-   ##
==========================================
+ Coverage   74.31%   79.40%   +5.09%     
==========================================
  Files         536      547      +11     
  Lines       23189    23618     +429     
  Branches     4056     4060       +4     
==========================================
+ Hits        17234    18755    +1521     
+ Misses       4853     3694    -1159     
- Partials     1102     1169      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants