Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azurite to an existing Azure Storage tutorial. #108

Merged
merged 21 commits into from
Dec 2, 2023
Merged

Add Azurite to an existing Azure Storage tutorial. #108

merged 21 commits into from
Dec 2, 2023

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 30, 2023 •
edited by github-actions bot
Loading

Summary

  • Add zone pivots for Azurite, Azure Portal, and Azure CLI.
  • Add snippet bits / replace inline code.
  • Add conditional sample rendering based on zone.
  • Clean up source code.

Fixes #78

Internal previews

📄 File 🔗 Preview link
docs/storage/azure-storage.md Tutorial: Connect an ASP.NET Core app to .NET Aspire storage components

@IEvangelist IEvangelist changed the title WIP Add Azurite to an existing Azure Storage tutorial. Nov 30, 2023
@IEvangelist IEvangelist marked this pull request as ready for review November 30, 2023 21:34
tdykstra
tdykstra approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of suggestions.

docs/storage/azure-storage.md Outdated Show resolved Hide resolved
docs/storage/azure-storage.md Outdated Show resolved Hide resolved
docs/storage/azure-storage.md Outdated Show resolved Hide resolved
docs/storage/azure-storage.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist enabled auto-merge (squash) December 2, 2023 02:12
@IEvangelist IEvangelist merged commit 574dea9 into dotnet:main Dec 2, 2023
7 checks passed
@IEvangelist IEvangelist mentioned this pull request Dec 2, 2023
Open
@IEvangelist IEvangelist deleted the azurite branch December 5, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwolfmsft alexwolfmsft alexwolfmsft left review comments

@eerhardt eerhardt eerhardt left review comments

@davidfowl davidfowl davidfowl left review comments

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Azure Storage Documentation with Azurite Integration
5 participants
@IEvangelist @davidfowl @tdykstra @eerhardt @alexwolfmsft