Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More JavaScript content #1646

Merged
merged 11 commits into from
Sep 11, 2024
Merged

More JavaScript content #1646

merged 11 commits into from
Sep 11, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Sep 11, 2024 •
edited by github-actions bot
Loading

Summary

  • Added missing AppHost content.
  • Add links to the Node.js sample and add some content around that for OTEL.
  • Edit pass + Acrolinx
  • Added parameter links and mention secrets/env vars.

Fixes #1585, /cc @indcoder.

Internal previews

📄 File 🔗 Preview link
docs/get-started/build-aspire-apps-with-nodejs.md docs/get-started/build-aspire-apps-with-nodejs

@dotnet-bot dotnet-bot added the getting-started Content related to getting started. label Sep 11, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-freshness OKR: Freshness of content label Sep 11, 2024
tdykstra
tdykstra approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a typo and a missing word.

docs/get-started/build-aspire-apps-with-nodejs.md Outdated Show resolved Hide resolved
docs/get-started/build-aspire-apps-with-nodejs.md Outdated Show resolved Hide resolved
@IEvangelist IEvangelist enabled auto-merge (squash) September 11, 2024 18:27
@IEvangelist IEvangelist merged commit 296ef57 into dotnet:main Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
getting-started Content related to getting started. okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add adding existing node.js APIs to Javascript examples
3 participants
@IEvangelist @tdykstra @dotnet-bot