Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing docs #1874

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Testing docs #1874

merged 13 commits into from
Oct 22, 2024

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Oct 21, 2024

Summary

Started to expand the docs on testing to cover some more advanced aspects of testing. Focused on approaches to manage the app host within test runs and accessing the resources that are available in the app host during a test.

Fixes #1516


Internal previews

📄 File 🔗 Preview link
.github/dependabot.yml Generated by dependabot-bot.
docs/fundamentals/setup-tooling.md .NET Aspire setup and tooling
docs/testing/accessing-resources.md Access resources in .NET Aspire tests
docs/testing/manage-app-host.md Manage the app host in .NET Aspire tests
docs/testing/write-your-first-test.md docs/testing/write-your-first-test
docs/toc.yml docs/toc
docs/whats-new/dotnet-docs-aspire-mod0.md .NET Aspire docs: What's new for September 2024

@dotnetrepoman dotnetrepoman bot added the fundamentals Content related to fundamentals. label Oct 21, 2024
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you so much! I provided a lot of suggestions, but that's to ensure that this content aligns with the expected quality, consistency, and styling of the docs. I didn't approve this yet, as I want to have another look once suggestions are applied. Also, we need to determine if this is going into the .NET Aspire 9 GA release branch or main.

docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
docs/testing/accessing-resources.md Outdated Show resolved Hide resolved
@aaronpowell
Copy link
Contributor Author

This looks great, thank you so much! I provided a lot of suggestions, but that's to ensure that this content aligns with the expected quality, consistency, and styling of the docs. I didn't approve this yet, as I want to have another look once suggestions are applied.

Appreciate all the feedback, making sure that everything is the same stylistically and structurally is important.

Also, we need to determine if this is going into the .NET Aspire 9 GA release branch or main.

The content is valid in 8.x and from what I've seen there isn't anything major changing in the testing structure for 9.0 so it'll come down to your choice on what you prefer the ship timeline to be.

@aaronpowell
Copy link
Contributor Author

All the suggestions should have been applied now (some caused problems in VS Code when applying)

@IEvangelist IEvangelist enabled auto-merge (squash) October 22, 2024 00:47
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit 34e356a into dotnet:main Oct 22, 2024
7 checks passed
@aaronpowell aaronpowell mentioned this pull request Oct 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution fundamentals Content related to fundamentals. okr-freshness OKR: Freshness of content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics on testing
2 participants